Bug 55713

Summary: prints wrong values for Disposal method and Color Resolution
Product: [Retired] Red Hat Linux Reporter: Asko Tontti <atontti+rh>
Component: giftransAssignee: Phil Knirsch <pknirsch>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-11-05 15:40:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
fix for the bug. Use parentheses to fix operator precedence errors none

Description Asko Tontti 2001-11-05 15:38:17 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5+) Gecko/20011104

Description of problem:
The source code of giftrans has C operator precedence errors which
cause wrong values to be used when printing "Disposal method" and
"Color Resolution".

I have a patch for this bug.

Version-Release number of selected component (if applicable):
  giftrans-1.12.2-9


How reproducible:
Always

Steps to Reproduce:
1. giftrans -L harrycanuck.gif |& grep -i method


Actual Results:
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)


Expected Results:
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)


Additional info:

Take (or create with GIMP) any animated GIF with different disposal
methods to test.

Comment 1 Asko Tontti 2001-11-05 15:40:47 UTC
Created attachment 36462 [details]
fix for the bug. Use parentheses to fix operator precedence errors

Comment 2 Phil Knirsch 2001-11-06 15:42:22 UTC
Fixed in rawhide, version giftrans-1.12.2-10

Read ya, Phil