Bug 602767
| Summary: | Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
huzaifas: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-18 09:20:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 599859 | ||
|
Description
Petr Pisar
2010-06-10 17:30:53 UTC
OK rpmlint checks return: [marca@caladan SRPMS]$ rpmlint perl-MooseX-MarkAsMethods-0.08-1.fc13.src.rpm perl-MooseX-MarkAsMethods.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-MooseX-MarkAsMethods.src: W: spelling-error %description -l en_US autoclean -> auto clean, auto-clean, autoclave 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [marca@caladan SRPMS]$ rpmlint ../RPMS/noarch/perl-MooseX-MarkAsMethods-0.08-1.fc13.noarch.rpm perl-MooseX-MarkAsMethods.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-MooseX-MarkAsMethods.noarch: W: spelling-error %description -l en_US autoclean -> auto clean, auto-clean, autoclave 1 packages and 0 specfiles checked; 0 errors, 2 warnings. OK package meets naming guidelines OK package meets packaging guidelines OK license (LGPLv2+) OK, text in %doc, matches source OK spec file legible, in am. english OK source matches upstream OK package compiles on devel (x86) OK no missing BR OK no unnecessary BR OK no locales OK not relocatable OK owns all directories that it creates OK no duplicate files OK permissions ok OK %clean ok OK macro use consistent OK code, not content OK no need for -docs OK nothing in %doc affects runtime OK no need for .desktop file New version 0.09 is available. Please update, the latest version is fixing version of Moose in requirements. Both readme could stay in package. Both spelling errors are false; The words are literals (perl package name). New version 0.09 does not provide fix. It still does not updates required version in the module itself. Upstream noticed. Do you mind reviewing 0.08? Both versions are almost identical. The 0.08 spec includes both REAMDE files yet. Marcela, could accept this package and set review flag to +? ACCEPTED New Package CVS Request ======================= Package Name: perl-MooseX-MarkAsMethods Short Description: Mark overload code symbols as methods Owners: ppisar mmaslano psabata Branches: F-13 InitialCC: perl-sig cvs done Thank you for review and CVS update. Package built for F-14 and F-13. perl-MooseX-MarkAsMethods-0.10-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-MooseX-MarkAsMethods-0.10-1.fc13 perl-MooseX-MarkAsMethods-0.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |