Bug 615851

+ OK
- NA
? ISSUE

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
? Package has a correct %clean section.
? Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.

SHOULD Items:

+ Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
- Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1.rpmlint output:

[Ankur@localhost SPECS]$ rpmlint oflb-sportrop-fonts.spec ../SRPMS/oflb-sportrop-fonts-0.9-8.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm
oflb-sportrop-fonts.spec: W: no-cleaning-of-buildroot %install
oflb-sportrop-fonts.spec: W: no-cleaning-of-buildroot %clean
oflb-sportrop-fonts.spec: W: no-buildroot-tag
oflb-sportrop-fonts.spec: W: no-%clean-section
oflb-sportrop-fonts.spec: W: invalid-url Source0: http://openfontlibrary.org/people/gluk/gluk_-_Sportrop.zip HTTP Error 404: Not Found
oflb-sportrop-fonts.src: W: spelling-error Summary(en_US) multiline -> multilane, multilingual, multilevel
oflb-sportrop-fonts.src: W: spelling-error %description -l en_US multiline -> multilane, multilingual, multilevel
oflb-sportrop-fonts.src: W: invalid-url URL: http://openfontlibrary.org/media/files/gluk/287 HTTP Error 404: Not Found
oflb-sportrop-fonts.src: W: no-cleaning-of-buildroot %install
oflb-sportrop-fonts.src: W: no-cleaning-of-buildroot %clean
oflb-sportrop-fonts.src: W: no-buildroot-tag
oflb-sportrop-fonts.src: W: no-%clean-section
oflb-sportrop-fonts.src: W: invalid-url Source0: http://openfontlibrary.org/people/gluk/gluk_-_Sportrop.zip HTTP Error 404: Not Found
oflb-sportrop-fonts.noarch: W: spelling-error Summary(en_US) multiline -> multilane, multilingual, multilevel
oflb-sportrop-fonts.noarch: W: spelling-error %description -l en_US multiline -> multilane, multilingual, multilevel
oflb-sportrop-fonts.noarch: W: invalid-url URL: http://openfontlibrary.org/media/files/gluk/287 HTTP Error 404: Not Found
oflb-sportrop-fonts.src: W: spelling-error Summary(en_US) multiline -> multilane, multilingual, multilevel
oflb-sportrop-fonts.src: W: spelling-error %description -l en_US multiline -> multilane, multilingual, multilevel
oflb-sportrop-fonts.src: W: invalid-url URL: http://openfontlibrary.org/media/files/gluk/287 HTTP Error 404: Not Found
oflb-sportrop-fonts.src: W: no-cleaning-of-buildroot %install
oflb-sportrop-fonts.src: W: no-cleaning-of-buildroot %clean
oflb-sportrop-fonts.src: W: no-buildroot-tag
oflb-sportrop-fonts.src: W: no-%clean-section
oflb-sportrop-fonts.src: W: invalid-url Source0: http://openfontlibrary.org/people/gluk/gluk_-_Sportrop.zip HTTP Error 404: Not Found
3 packages and 1 specfiles checked; 0 errors, 24 warnings.

Ignorable warnings. 

Please check the buildroot and clean section before you create a cvs module. 

Rest looks okay.

XXX APPROVED XXX

Thanks for the review!

New Package CVS Request
=======================
Package Name: oflb-sportrop-fonts
Short Description: A multiline decorative font
Owners: pnemade
Branches: 
InitialCC: i18n-team fonts-sig

CVS done (by process-cvs-requests.py).

Thanks all. Built in rawhide.