Bug 617300

This issue has been proposed when we are only considering blocker
issues in the current Red Hat Enterprise Linux release.

** If you would still like this issue considered for the current
release, ask your support representative to file as a blocker on
your behalf. Otherwise ask that it be considered for the next
Red Hat Enterprise Linux release. **

According to http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html only start, stop, restart, force-reload, and status are required to be implemented by all init scripts. The other actions you mention are optional. And since they doesn't make any sense for this particular script, they are not implemented.

Looking at the link you posted, I see that those actions are, however, required by Fedora packaging guidelines so the summary is quite misleading...

(In reply to comment #2)
> According to
> http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> only start, stop, restart, force-reload, and status are required to be
> implemented by all init scripts. The other actions you mention are optional.
> And since they doesn't make any sense for this particular script, they are not
> implemented.
> 
> Looking at the link you posted, I see that those actions are, however, required
> by Fedora packaging guidelines so the summary is quite misleading...    

Yes indeed. I was thinking maybe do nothing and return 0? I don't know what to make of this, libvirt-guests is not a deamon running, it's just a service to handle guests during bootup/shutdown.

Even though there is no daemon process (and thus no daemon pid to track), we do
handle two pieces of state - whether guests have been saved (if so, we are
necessarily stopped), and whether the lock file exists (so that the system
knows whether it is essential to call 'libvirt-guests stop' at shutdown time). 
I think both pieces of information are useful in 'libvirt-guests status'
output; at which point, condrestart makes sense: save and restore guests if we
are already started, but don't start if there are already saved guests.  I'm
working on the appropriate patches...

I'm not sure condrestart makes sense... do you really want to bounce all guests on libvirtd upgrades?

To be more clear: if condrestart isn't a useful operation, just stub it out and return 0.

Patch series awaiting ACK at
http://post-office.corp.redhat.com/archives/rhvirt-patches/2010-July/msg00930.html

'restart' already bounces all guests, and 'condrestart' is documented as requiring the same behavior as 'restart' if the daemon is already started, but doing nothing if the daemon is stopped (that is, the difference between 'restart' and 'condrestart' is that 'restart' is guaranteed to restore guests and put us in a started state, while 'condrestart' must not restore guests if the user has not yet run 'start' or 'restart').

Looks reasonable to me.

libvirt-0_8_1-19_el6 has been built in RHEL-6-candidate with the fix.

Dave

I test it with the following result:

#service libvirt-guests usage
Usage: /etc/init.d/libvirt-guests {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}

# service libvirt-guests status
started

# egrep "condrestart|try-restart" /etc/init.d/libvirt-guests
    echo $"Usage: $0 {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}"
    condrestart|try-restart)

# grep "load" /etc/init.d/libvirt-guests |grep reload
    echo $"Usage: $0 {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}"
    reload|force-reload)

# service libvirt-guests sdkjflsj;echo $?
Usage: /etc/init.d/libvirt-guests {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}
2

so the bug is verified

[root@redhat ~]# rpm -qa libvirt
libvirt-0.8.1-20.el6.x86_64
[root@redhat ~]# uname -r
2.6.32-54.el6.x86_64

Verified with libvirt-0.8.1-27.el6.x86_64 & qemu-kvm-0.12.1.2-2.113.el6.x86_64.

# service libvirt-guests usage
Usage: /etc/init.d/libvirt-guests {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}

# service libvirt-guests status
started

# egrep "condrestart|try-restart" /etc/init.d/libvirt-guests
    echo $"Usage: $0 {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}"
    condrestart|try-restart)

# grep "load" /etc/init.d/libvirt-guests |grep reload
    echo $"Usage: $0 {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}"
    reload|force-reload)

# service libvirt-guests sdkjflsj;echo $?
Usage: /etc/init.d/libvirt-guests {start|stop|status|restart|condrestart|try-restart|reload|force-reload|gueststatus|shutdown}
2

Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.