Bug 619270
Summary: | livecd-creator imports Yum modules, ctrl-c during package transaction exits without letting livecd-creator cleanup properly | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jasper O'neal Hartline <Jasper.Hartline> |
Component: | yum | Assignee: | Packaging Maintenance Team <packaging-team-maint> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 19 | CC: | ffesti, james.antill, mads, Marc.Herbert+rhzilla, maxamillion, pmatilai, tim.lauridsen |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-02-17 13:18:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jasper O'neal Hartline
2010-07-29 06:28:14 UTC
It seems rpmUtils/miscutils.py: checkSignals() is always trapping SIGINT. I've found the only way to catch CTRL-C/KeyboardInterrupt/SIGINT from the user during runTransaction() is to initialize a signal handler right before runTransaction() happens inside of def install() in yuminst.py of livecd-tools/python-imgcreate. I am looking at the rest of livecd-tools/python-imgcreate and it appears that there are methods to clean up but this signal handling by rpm-python wasn't forseen, and instead appears as if we will always rely on the fact that runTransaction() completes successfully, which in some cases it won't. Any suggestions on how I should handle this from Yum's point of view? The fact is livecd-creator cannot cleanup properly, and I should work around this or have Yum/rpm-python not handle the signal but this seems incorrect. Does initializing a signal handler before runTransaction() seem more reasonable, and within it do what must happen to cleanup despite the already existing methods for unmounting and cleanup which was written in creator.py? FWIW here is my "make clean" target to workaround this problem: LIVECD_TMP ?= /var/tmp clean: - mount | grep "${LIVECD_TMP}"/imgcreate | awk '{print $$3}' | tac | \ while read mpoint; do sudo umount $$mpoint; done for lo in $$(sudo losetup -a | grep "${LIVECD_TMP}"/imgcreate | cut -d: -f1); do \ sudo losetup -d $$lo; done - sudo ${RM} -r "${LIVECD_TMP}"/imgcreate-* This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 Trying to make a LiveCD: livecd-creator -c kde-19.ks --releasever=19 -t /home/vk/tmp --cache=/home/vk/tmp/19 --verbose 2>&1 | tee kde-19.log LiveCD-creator of the work can not be done in Fedora 19, but well done on the same machine in Fedora 18 1. log in Fedora 19: http://fpaste.org/9059/13671906/ 2. log in Fedora 18: http://fpaste.org/9064/36719241/ thank you Making a 32-bit spin ISO on a 64-bit machine: # setarch i386 livecd-creator -c 368.ks --releasever=1 -t /home/vk/tmp --cache=/home/vk/tmp/19 --verbose 2>&1 | tee 368.log Operation stops with error output: Losetup remove /dev/loop1 BDB2053 Freeing read locks for locker 0x65: 4247/140581645281280 BDB2053 Freeing read locks for locker 0x66: 4247/140581645281280 BDB2053 Freeing read locks for locker 0x67: 4247/140581645281280 BDB2053 Freeing read locks for locker 0x68: 4247/140581645281280 Traceback (most recent call last): File "/bin/livecd-creator", line 237, in <module> sys.exit(main()) File "/bin/livecd-creator", line 227, in main logging.error(u"Error creating Live CD : %s" % e) File "/usr/lib/python2.7/site-packages/imgcreate/errors.py", line 45, in __unicode__ return unicode(self.message) UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 34: ordinal not in range(128) thank you I'm sorry, I was not paying attention: "--releasever=1 " = "--releasever=19" I'm sorry This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |