Bug 645604
| Summary: | Review Request: python-gflags - Commandline flags module for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Silas Sewell <silas> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-gflags-1.4-2.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-17 23:21:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Silas Sewell
2010-10-21 23:14:26 UTC
- rpmlint: $ rpmlint ./python-mox-0.5.3-1.fc14.src.rpm ./noarch/python-mox-0.5.3-1.fc14.noarch.rpm python-mox.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mox.py 0644L /usr/bin/python2.4 python-mox.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/stubout.py 0644L /usr/bin/python2.4 2 packages and 0 specfiles checked; 2 errors, 0 warnings. See: http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries (althought I'd prefer to remove them in %prep...) - I'd use the url from the readme: http://code.google.com/p/pymox/ - license ok - %check there - group ok - no *.la - no libs - noarch ok - how about the python3 support? ;-) It would be nice, if you could open a ticket at upstream: http://code.google.com/p/pymox/issues/list _______________________________________ Please fix at least the shebangs from above before importing. Rest is ok. _______________________________________ APPROVED Sorry, that review from above was for python-mox... Doing now another one for this one... rpmlint: $ rpmlint ./python-gflags-1.4-1.fc14.src.rpm ./noarch/python-gflags-1.4-1.fc14.noarch.rpm python-gflags.src: W: spelling-error Summary(en_US) Commandline -> Command line, Command-line, Commanding python-gflags.src: W: spelling-error %description -l en_US google -> Google, goggle, googly python-gflags.src: W: spelling-error %description -l en_US commandline -> command line, command-line, commanding python-gflags.src: W: spelling-error %description -l en_US getopt -> get opt, get-opt, getup python-gflags.src: W: invalid-url Source0: http://python-gflags.googlecode.com/files/python-gflags-1.4.tar.gz HTTP Error 404: Not Found python-gflags.noarch: W: spelling-error Summary(en_US) Commandline -> Command line, Command-line, Commanding python-gflags.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly python-gflags.noarch: W: spelling-error %description -l en_US commandline -> command line, command-line, commanding python-gflags.noarch: W: spelling-error %description -l en_US getopt -> get opt, get-opt, getup python-gflags.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/gflags.py 0644L /usr/bin/env python-gflags.noarch: W: no-manual-page-for-binary gflags2man 2 packages and 0 specfiles checked; 1 errors, 10 warnings. Please fix the non-excecutable-script error, see: http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries The rest is ignorable (invalid-url is false positive). - license ok - no libs - no *.la - rest also ok ___________________________ Please fix the non-executable-script error before importing. ___________________________ APPROVED ___________________________ Fixed above mentioned issue. SRPM: http://github.com/downloads/silas/rpms/python-gflags-1.4-2.fc13.src.rpm New Package CVS Request ======================= Package Name: python-gflags Short Description: Commandline flags module for Python Owners: silas Branches: F-13 F-14 EL-5 EL-6 InitialCC: Git done (by process-git-requests). python-gflags-1.4-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-gflags-1.4-2.fc14 python-gflags-1.4-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/python-gflags-1.4-2.fc13 python-gflags-1.4-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python-gflags-1.4-2.el5 python-gflags-1.4-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-gflags'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-gflags-1.4-2.fc13 python-gflags-1.4-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. python-gflags-1.4-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. python-gflags-1.4-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |