Bug 755141

Summary: Review Request: gnome-system-log - A log viewer for GNOME
Product: [Fedora] Fedora Reporter: Matthias Clasen <mclasen>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: hedayaty, notting, package-review, panemade
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-21 19:16:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Matthias Clasen 2011-11-19 00:58:11 UTC
Another piece that formerly lived in gnome-utils.

srpm: http://mclasen.fedorapeople.org/gnome-system-log-3.3.1-1.fc16.src.rpm
spec: http://mclasen.fedorapeople.org/gnome-system-log.spec

Comment 1 Amir Hedayaty 2011-11-19 09:43:36 UTC
Build Failed
Here is the last part of output of rpmbuild -bb commonad 

checking for inflate in -lz... yes
checking for LOGVIEW... no
configure: error: Package requirements (glib-2.0 >= 2.31.0
                  gtk+-3.0 >= 3.0.0) were not met:

Requested 'glib-2.0 >= 2.31.0' but version of GLib is 2.30.1

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables LOGVIEW_CFLAGS
and LOGVIEW_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
error: Bad exit status from /var/tmp/rpm-tmp.4yu33w (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.4yu33w (%build)

Comment 2 Parag AN(पराग) 2011-11-19 14:43:23 UTC
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3525753

+ rpmlint on rpms gave
gnome-system-log.src:43: W: macro-in-comment %{name}
gnome-system-log.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-system-log-3.3.1/COPYING
gnome-system-log.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-system-log-3.3.1/COPYING.docs
2 packages and 0 specfiles checked; 2 errors, 1 warnings.

+ source matched with upstream as (sha1sum)
dda64fba12539787b439d61c2912f7119f327fd5  gnome-system-log-3.3.1.tar.xz
dda64fba12539787b439d61c2912f7119f327fd5  ../SOURCES/gnome-system-log-3.3.1.tar.xz

+ Follows packaging guidelines

Suggestions:
1) Fix the marco-in-comment warning in spec.


APPROVED.

Comment 3 Parag AN(पराग) 2011-11-19 14:44:35 UTC
Amir,
   you should check that package is building successfully either in mock or on koji. See http://fedoraproject.org/wiki/Extras/MockTricks

Comment 4 Matthias Clasen 2011-11-21 13:54:46 UTC
Sorry, I forgot to mention that it will only build in rawhide due to the GLib 2.31 dep.

Comment 5 Matthias Clasen 2011-11-21 14:00:41 UTC
New Package SCM Request
=======================
Package Name: gnome-system-log
Short Description: A log file viewer for GNOME
Owners: mclasen, cosimoc, rstrode
Branches: 
InitialCC:

Comment 6 Gwyn Ciesla 2011-11-21 14:52:08 UTC
Git done (by process-git-requests).

Comment 7 Matthias Clasen 2011-11-21 19:16:33 UTC
Build done as well.