Bug 911781 (bittwist)

Summary: Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
Product: [Fedora] Fedora Reporter: Giuseppe Marco Randazzo <gmrandazzo>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: cristian.ciupitu, echevemaster, gmrandazzo, mail, package-review, rebus
Target Milestone: ---Flags: mail: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 563471    
Attachments:
Description Flags
bittwist new spec file
none
bittwist-Makefile patch
none
bittwist-2.0-2 SRC RPM 2014-07-15
none
bittwist spec file 2014-07-15
none
bittwist Make file patch 2014-07-15 none

Description Giuseppe Marco Randazzo 2013-02-15 23:37:43 UTC
Spec URL: https://raw.github.com/zeld/var/master/bittwist.spec
SRPM URL: https://raw.github.com/zeld/var/master/bittwist-2.0-1.fc18.src.rpm

Description: Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator. It is designed to complement tcpdump, which by itself has done a great job at capturing network traffic.
With Bit-Twist, you can now regenerate your captured traffic onto a live network! Packets are generated from tcpdump trace file (.pcap file). Bit-Twist also comes with a comprehensive trace file editor to allow you to change the contents of a trace file.

Generally, packet generator is useful in simulating networking traffic or scenario, testing firewall, IDS, and IPS, and troubleshooting various network problems.

Fedora Account System Username: I do not have any account... i'm not able to make account because in the register form there is an error...

Comment 1 Eduardo Echeverria 2013-02-16 06:37:28 UTC
Hi Giuseppe 

About review process

Perhaps you have tried to register at any time when the platform was not available, however, and the expectation that you are searching a different url, you retry with this.

https://admin.fedoraproject.org/accounts/

These links may be useful:
- https://fedoraproject.org/wiki/Package_Review_Process#Contributor
- https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Use_rpmlint

Is good practice paste the rpmlint output in the review, and at least make a build scratch on koji and paste the link in the review

https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds

Please tag the field "Blocks" with the word FE-NEEDSPONSOR. So, will let you know the sponsors you need sponsorship  

About the package 

I have not thoroughly checked the package, but at first glance,  I give some recommendations

You have a typo in this line
URL:		http://http://bittwist.sourceforge.net/

in %install
make install prefix=${RPM_BUILD_ROOT}/usr
should be 
make install DESTDIR=%{buildroot} PREFIX=%{_prefix}

(if $DESTDIR supports)

Check it
$ rpm --eval %{_prefix}
/usr

the description should not be more than 80 characters per line, rpmlit complains with description-line-too-long

- Please do honors applicable compiler flags, Use %{optflags}

Check it
$ rpm --eval %{optflags}
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic


Check the makefile and do the patch, (do not forget to send the patch to upstream)

bittwist:
        $(CC) $(CFLAGS) $(SRC)/bittwist.c -o $(SRC)/bittwist -I/usr/local/include -L/usr/local/lib -lpcap

bittwiste:
        $(CC) $(CFLAGS) $(SRC)/bittwiste.c -o $(SRC)/bittwiste -I/usr/local/include -L/usr/local/lib -lpcap

- the tag license is wrong 
License:	GPL2
should be
License:        GPLv2

the changelog is wrong
%changelog
* Fri Feb 15 2013 Giuseppe Marco Randazzo <gmrandazzo@gmail.com>
- first build for bittwist
should be
%changelog
* Fri Feb 15 2013 Giuseppe Marco Randazzo <gmrandazzo@gmail.com> - 2.0-1
- first build for bittwist

https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

- Don't needed %defattr(-,root,root)

Kind Regards

Comment 2 Fabian Affolter 2014-01-21 12:53:24 UTC
Giuseppe, are you still interested to go on with this package?

Comment 3 Fabian Affolter 2014-06-14 07:01:43 UTC
Giuseppe?

Comment 4 Giuseppe Marco Randazzo 2014-06-23 19:01:35 UTC
Hello, yes i am still interested.... sorry for the delay!! :-) Here all the modifications!! I hope now the spec file and the patch are fine!

Thanks!!

Giuseppe Marco Randazzo

Comment 5 Giuseppe Marco Randazzo 2014-06-23 19:02:35 UTC
Created attachment 911551 [details]
bittwist new spec file

New Bitwist spec file

Comment 6 Giuseppe Marco Randazzo 2014-06-23 19:04:28 UTC
Created attachment 911552 [details]
bittwist-Makefile patch

The bittwist-Makefile patch.


~ Added the DESTDIR support
~ Fixed the make procedure to use the optflags

Comment 7 Fabian Affolter 2014-07-15 12:30:10 UTC
Can you please provide updated files (spec and SRPM)? Thanks.

Comment 8 Giuseppe Marco Randazzo 2014-07-15 12:42:36 UTC
Created attachment 918154 [details]
bittwist-2.0-2 SRC RPM  2014-07-15

SRC RPM bittwist 2.0-2

Comment 9 Giuseppe Marco Randazzo 2014-07-15 12:43:39 UTC
Created attachment 918155 [details]
bittwist spec file 2014-07-15

bittwist spec file 2014-07-15

Comment 10 Giuseppe Marco Randazzo 2014-07-15 12:44:35 UTC
Created attachment 918156 [details]
bittwist Make file patch 2014-07-15

bittwist 2.0-2 Make file patch 2014-07-15

Comment 11 Fabian Affolter 2015-03-04 09:48:40 UTC
Can you please provide updated files (spec and SRPM)? Not as attachment to the report but rather as links. Thanks.

Comment 12 Eduardo Echeverria 2015-03-05 06:18:20 UTC
I'm still interested in know what is the fas of Giuseppe and if still he hasn't been sponsored. Like says Fabian, Giuseppe, please append the links of the spec and SRPM, usually reviewers use a tool named fedora-review, that expects those links be available at the review.