Bug 98184

Summary: cupsaddsmb incorrectly configures Windows 9x drivers
Product: [Retired] Red Hat Linux Reporter: Jack Johnson <fragment>
Component: cupsAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 9   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.1.19-8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2003-07-07 14:27:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Jack Johnson 2003-06-27 17:25:05 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b)
Gecko/20030515 Mozilla Firebird/0.6

Description of problem:
When running cupsaddsmb, it incorrectly calls rpcclient:

rpcclient localhost -N -U'root%password' -c 'adddriver "Windows 4.0"
"test2:ADOBEPS4.DRV:test2.PPD:NULL:ADOBEPS4.HLP:PSMON.DLL:RAW:ADOBEPS4.DRV:test2.PPD,ADOBEPS4.HLP,PSMON.DLL,ADFONTS.MFM,DEFPRTR2.PPD,ICONLIB.DLL"'

According to the rpcclient man page:

  The config parameter is defined as follows:

                   Long Printer Name:\
                   Driver File Name:\
                   Data File Name:\
                   Config File Name:\
                   Help File Name:\
                   Language Monitor Name:\
                   Default Data Type:\
                   Comma Separated list of Files

If you check the entry in the call, there's one too many colons, and as a result
only the first file in the driver list gets installed on the client.

The fix is easy, in cups-1.1.17/systemv/cupsaddssmb.c:

# diff cupsaddsmb.c.orig cupsaddsmb.c.new
477c477
<           
"ADOBEPS4.DRV:%s.PPD,ADOBEPS4.HLP,PSMON.DLL,ADFONTS.MFM,DEFPRTR2.PPD,ICONLIB.DLL\"",
---
>           
"ADOBEPS4.DRV,%s.PPD,ADOBEPS4.HLP,PSMON.DLL,ADFONTS.MFM,DEFPRTR2.PPD,ICONLIB.DLL\"",

It could probably be done with a patch.

I have not checked the current cups sources at easysw.com yet.


Version-Release number of selected component (if applicable):
cups-1.1.17-13.3

How reproducible:
Always

Steps to Reproduce:
1. install & configure samba, cups & the Adobe PostScript drivers per the
documentation
2. run cupsaddsmb -U whoever -a
3. use a Win9x host to attempt to automatically install the drivers
    

Actual Results:  The complete set of drivers do not load on the Win9x host.

Expected Results:  The complete set of drivers should have loaded on the Win9x host.

Additional info:

See description

Comment 1 Tim Waugh 2003-07-07 14:27:08 UTC
This is fixed in CUPS-1.1.19, which is now in rawhide.  Thanks.