|Summary:||UTF-8 locale and empty tips|
|Product:||[Fedora] Fedora||Reporter:||Akira TAGOH <tagoh>|
|Component:||gimp||Assignee:||Nils Philippsen <nphilipp>|
|Status:||CLOSED RAWHIDE||QA Contact:||David Lawrence <dkl>|
|Fixed In Version:||1.2.5-2||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2004-09-13 03:32:11 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Bug Depends On:||101377|
Description Akira TAGOH 2003-07-03 08:04:51 UTC
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.2.1) Gecko/20030225 Description of problem: When I run GIMP with UTF-8 locale, empty tips are displayed so that the tips files is stored as the legacy encoding. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1.LANG=ja_JP.UTF-8 gimp, for example 2. 3. Additional info:
Comment 1 Leon Ho 2003-08-05 02:40:48 UTC
Okay.. Should we iconv all tips text file to UTF-8 for Cambridge?
Comment 2 Akira TAGOH 2003-08-05 13:18:10 UTC
Yes, it should solves this problem.
Comment 3 Akira TAGOH 2003-12-11 01:55:26 UTC
Created attachment 96465 [details] proposed patch the encoding of tips files can be guessed from the po files, I think. so attached patch will just try to convert all tips files to UTF-8.
Comment 4 Matt Wilson 2003-12-15 19:45:29 UTC
*** Bug 110329 has been marked as a duplicate of this bug. ***
Comment 5 Akira TAGOH 2003-12-24 06:35:31 UTC
Created attachment 96690 [details] patch to iconv UTF-8 tips files to the native locale This patch also supports to be ran on the native locale.
Comment 6 Akira TAGOH 2004-04-07 04:50:11 UTC
how is this going on? and can we get a chance to fix this on FC1 updates? This problem causes really unusable for the newbie gimp users who want to know the tips on Japanese.
Comment 7 Nils Philippsen 2004-04-08 08:13:57 UTC
I'm looking at the patch now and will likely put an updated package out soon.
Comment 8 Nils Philippsen 2004-04-08 08:15:09 UTC
BTW: Am I supposed to apply both patches or only the second one?
Comment 9 Nils Philippsen 2004-04-08 08:52:31 UTC
I looked at your second patch and it seems like it isn't quite consistent in using newly allocated and static strings... Guess I'll need to overhaul the patch a bit.
Comment 10 Nils Philippsen 2004-04-08 09:01:52 UTC
Created attachment 99229 [details] overhauled patch to iconv UTF-8 tips files to the native locale this patch strdup()s in store_tip() so we only have newly allocated strings in tips_text.
Comment 11 Nils Philippsen 2004-04-08 09:19:54 UTC
Created attachment 99230 [details] fixed overhauled patch to iconv UTF-8 tips files to the native locale D'oh
Comment 12 Nils Philippsen 2004-04-08 09:42:40 UTC
Guess I'll have to apply the first patch as well...
Comment 13 Akira TAGOH 2004-04-09 03:26:23 UTC
Yes, the patch is assuming all of po files are UTF-8.
Comment 14 Nils Philippsen 2004-04-16 12:49:42 UTC
please test gimp-1.2.5-2
Comment 15 Akira TAGOH 2004-04-19 02:51:03 UTC
confirmed the fix. thanks.
Comment 16 Akira TAGOH 2004-05-17 09:01:33 UTC
doh, this package wasn't pushed to FC1-updates. reopening and reverting the status.