Bug 1000006

Summary:	[JBossAS7] - it is possible to create an XA datasource even without required property
Product:	[Other] RHQ Project	Reporter:	Filip Brychta <fbrychta>
Component:	Plugins	Assignee:	Thomas Segismont <tsegismo>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.8	CC:	hrupp, tsegismo
Target Milestone:	---
Target Release:	RHQ 4.9
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-24 19:08:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Filip Brychta 2013-08-22 13:52:24 UTC

Description of problem:
During creation of XA datasource, the GUI wizard shows as required only following properties: Xa Datasource Class, Jndi Name , Driver Name. When all these properties are correctly set, the creation fails anyway because of following error: 
Datasource was added but not enabled: JBAS010469: At least one xa-datasource-property is required for an xa-datasource, rolled-back=true

Admin console in eap6 (i.e. http://10.16.23.97:9990/console) doesn't allow to create an XA datasource without at least one xa-datasource-property. RHQ should follow this behaviour.


Version-Release number of selected component (if applicable):
Version: 4.9.0-SNAPSHOT
Build Number: 434b099

How reproducible:
Always

Comment 1 Thomas Segismont 2013-08-27 10:31:09 UTC

Fixed in master

commit f613d685c6e4f87fe8616abb2fb4ebba6558900c
Author: Thomas Segismont <tsegismo>
Date:   Tue Aug 27 12:28:52 2013 +0200

Updated ConfigurationEditor and ConfigurationUtility to validate lists of maps size against configuration definition
Updated DatasourceComponent and as7 plugin descriptor, at least one connection property is required for XA Datasources

Tested on Standalone AS7 and Domain EAP6.1 with GUI and CLI

Comment 2 Thomas Segismont 2013-08-27 13:00:50 UTC

Additional commit in master

commit 8a0e879aa7505a27695af642d28fa71748281e6d
Author: Thomas Segismont <tsegismo>
Date:   Tue Aug 27 14:58:58 2013 +0200

Replace String.format with String concatenation in core domain class as String.format is not emulated by Gwt

Comment 3 Filip Brychta 2013-08-29 10:22:30 UTC

Verified on
Version: 4.9.0-SNAPSHOT
Build Number: e3e001b

GUI and CLI, EAP6.0.0GA

Comment 4 Heiko W. Rupp 2013-09-24 19:08:43 UTC

Bulk closing of RHQ 4.9 verified items