Bug 1000175
Summary: | Metrics UI tab does not refresh properly between different resources | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Stefan Negrea <snegrea> |
Component: | Core UI | Assignee: | Mike Thompson <mithomps> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 4.9 | CC: | ahovsepy, gerhard.dreschler, hrupp, jshaughn, mithomps |
Target Milestone: | ER02 | ||
Target Release: | RHQ 4.10 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | RHQ 4.9.0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-04-23 12:31:34 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 924725 |
Description
Stefan Negrea
2013-08-22 21:09:30 UTC
The fix to keep the selected metric graphs open, added state to the metrics view. This was being held when switching resources. I added logic to preserve the state in the view of selected(opened) graphs only if the resource did not change. Committed to master commit id: 6262b38 This is still an issue in the 4.9 release. After some investigation it seems the root cause is that the metrics time range "slides" forward on each refresh. The range is actually stored as a set of user preferences and by default a user preference update causes a page reload, ostensibly to then apply the change to the current page. But the metrics view is already updating on a scheduled interval. This causes a redundant refresh, at the CoreGUI.refresh level, that conflicts (sometimes, not always) with the auto-refresh update of the view. re-assigning to myself, setting back to ON-DEV and re-targeting for 4.10. The suto refresh should now be working. It should also be faster, with more of an "in-place" update since the page refresh no longer happens. Also, the avail detail, if open, no longer collapses on refresh. master commit 1235addbf5e819b8b18f5b5ee4a92b4c1bf2d51e Author: Jay Shaughnessy <jshaughn> Date: Sat Sep 14 22:15:16 2013 -0400 Fix refresh issue brought on by the fact that when the metric view refreshed istelf it updated the user prefs tracking the "sliding" time range, which in turn triggered the standard CoreGUI.refresh that refreshed the entire page. These stepped on each other. - Enhance UserPreferences API to let the caller suppress refresh on preference change. - Use the new UserPreferences hooks in ButtonBarDateTimeEditor and MeasurementUserPreferences to suppress refresh as needed. - Restructure MetricsResourceView to minimize impact when asked to refreshData. Now also maintains availDetail collapse state on auto refresh. - Add isRefreshing support to AbstractD3GraphListView (although this is not likely to be needed, it's a little more protection) Still a couple side effects to fix here. The side effects were fixed and committed to master for ER02. commit id: 1334459 and 3507a4d verified in ER5 video here -> http://d.pr/v/CQbB Bulk closing of 4.10 issues. If an issue is not solved for you, please open a new BZ (or clone the existing one) with a version designator of 4.10. |