Bug 1000275

Why did you copy the spec from repo?

Because it was recommended that I do that, no need to make a completely new one after all. I've tested it with mock and it builds fine (I'm using it right now actually).

Sorry that the links aren't direct BTW, I've opened a ticket to request use of my fedorapeople space...

I will take this review.

Could you please re-upload them somewhere with a direct URL, for retainment, though?

Please remove the obsolete lines before second upload. 

As a new packager you should read through the spec guidelines. NOT JUST COPY AND PASTE

(In reply to Patrick Uiterwijk from comment #4)
> I will take this review.
> 
> Could you please re-upload them somewhere with a direct URL, for retainment,
> though?

Thanks Patrick! Yes, I'll make some changes and then put them up. Hopefully I'll have access to fedorapeople by then, if not I'll use some other file host.

(In reply to Christopher Meng from comment #5)
> Please remove the obsolete lines before second upload. 
> 
> As a new packager you should read through the spec guidelines. NOT JUST COPY
> AND PASTE

Thanks, will read them through and make changes.

After some changes:
https://dl.dropboxusercontent.com/s/6agxajo8n222pmb/nitrogen-1.5.2-6.fc19.src.rpm?token_hash=AAFAkdhmHj8YeLUfT3bdonl9ClTgNbiKK-rjrW38UA-8lg&dl=1
https://dl.dropboxusercontent.com/s/oiccjhmvnj288jj/nitrogen.spec?token_hash=AAHM_V33TlrCP43mSHkScw0sq2OtgbbjlZ-mMT0a4t_5aQ&dl=1

Both are direct links. I haven't got access to fedorapeople yet or I would use it instead.

Made one change to the spec file, that's all (removed %check section).

http://jamesnz.fedorapeople.org/nitrogen/nitrogen-1.5.2-6.fc19.src.rpm
http://jamesnz.fedorapeople.org/nitrogen/nitrogen.spec

Okay, the issues I have with this version are:

- The NVR of the last changelog entry and the file specification do not mtach. Please increase the Release tag.
- The last release (1.5.2) is from 2011. Maybe you should ask upstream to upload a new release.
- You have duplicate file names listed: %{_datadir}/icons/hicolor/*/apps/%{name}.png also matches %{_datadir}/icons/hicolor/128x128/apps/%{name}.png
- You have an old version of the Icon Cache snippet. Please update from http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- If you are not planning to build for EPEL5, please remove the Buildroot tag
- Same for the first line of %install and with the complete %clean section
- Please only use one type of variables: do not use both $-style and %-style (e.g. $RPM_BUILD_ROOT vs %{_datadir}) mixed
- Please add %{optflags} to the make command, or explain why you can't
- Please use a real email address in the changelog, so don't use the "jamesnz at fedoraproject.org" syntax
- Please note I'm not sure I really like the fact that it has such generic filenames (%{_datadir}/icons/hicolor/16x16/mimetypes/image-x-generic.png for example). Are you very sure they don't clash with any other package?

Please note that these are the issues found so far. After fixing them, I might have new ones :).
Also, please update the srpm and the spec file at the same time.

Ok, I think I've fixed everything except for the age of the release. I've opened a GitHub ticket for that (https://github.com/l3ib/nitrogen/issues/39) but haven't recieved any reply yet.

I've also gone through the all the icon files and verified that they don't conflict with other packages:

[root@paranoiainc ~]# yum provides /usr/share/icons/hicolor/16x16/mimetypes/image-x-generic.png /usr/share/icons/hicolor/16x16/actions/wallpaper-*.png /usr/share/icons/hicolor/16x16/devices/video-display.png
Loaded plugins: langpacks, refresh-packagekit
nitrogen-1.5.2-6.fc19.x86_64 : Background browser and setter for X windows
Repo        : installed
Matched from:
Filename    : /usr/share/icons/hicolor/16x16/mimetypes/image-x-generic.png



nitrogen-1.5.2-6.fc19.x86_64 : Background browser and setter for X windows
Repo        : installed
Matched from:
Filename    : /usr/share/icons/hicolor/16x16/actions/wallpaper-centered.png



nitrogen-1.5.2-6.fc19.x86_64 : Background browser and setter for X windows
Repo        : installed
Matched from:
Filename    : /usr/share/icons/hicolor/16x16/actions/wallpaper-scaled.png



nitrogen-1.5.2-6.fc19.x86_64 : Background browser and setter for X windows
Repo        : installed
Matched from:
Filename    : /usr/share/icons/hicolor/16x16/actions/wallpaper-tiled.png



nitrogen-1.5.2-6.fc19.x86_64 : Background browser and setter for X windows
Repo        : installed
Matched from:
Filename    : /usr/share/icons/hicolor/16x16/actions/wallpaper-zoomed.png



nitrogen-1.5.2-6.fc19.x86_64 : Background browser and setter for X windows
Repo        : installed
Matched from:
Filename    : /usr/share/icons/hicolor/16x16/devices/video-display.png



New links:
http://jamesnz.fedorapeople.org/nitrogen/nitrogen-1.5.2-7.fc19.src.rpm
http://jamesnz.fedorapeople.org/nitrogen/nitrogen.spec

Please note you still have the bogus syntax email in your spec file, please replace the "at" by "@".

Done, I've updated the spec, links are the same.

Looks fine to me.

APPROVED.

New Package SCM Request
=======================
Package Name: nitrogen
Short Description: Background browser and setter for X windows
Owners: jamesnz puiterwijk
Branches: f19
InitialCC:

New Package SCM Request
=======================
Package Name: nitrogen
Short Description: Background browser and setter for X windows
Owners: jamesnz puiterwijk
Branches: f19 f20
InitialCC:

Requested package name nitrogen doesn't match bug summary Nitrogen, please
correct.

Unretired, take ownership of devel and f19, possibly f18, in pkgdb, then
file package change request for f20 branch.

Package Change Request
======================
Package Name: nitrogen
New Branches: f20
Owners: puiterwijk jamesnz
InitialCC: 

Change request for f20 branch.

Mistakenly put puiterwijk as first owner.

Package Change Request
======================
Package Name: nitrogen
New Branches: f20
Owners: jamesnz puiterwijk
InitialCC:

Git done (by process-git-requests).

nitrogen-1.5.2-7.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nitrogen-1.5.2-7.fc19

nitrogen-1.5.2-7.fc19 has been pushed to the Fedora 19 testing repository.

nitrogen-1.5.2-7.fc19 has been pushed to the Fedora 19 stable repository.