Bug 1000430

Summary: konkretcmpi: __KReturn2 function should have format string annotation
Product: Red Hat Enterprise Linux 7 Reporter: Florian Weimer <fweimer>
Component: konkretcmpiAssignee: Radek Novacek <rnovacek>
Status: CLOSED CURRENTRELEASE QA Contact: qe-baseos-daemons
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: ovasik, rhack
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: konkretcmpi-0.9.1-3.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-11 18:09:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 999043    

Description Florian Weimer 2013-08-23 12:42:17 UTC 
__KReturn2 in konkret/konkret.h lacks a printf format string attribute.  If you add that, GCC will check for mismatches at compile time:

http://docs.fedoraproject.org/en-US/Fedora_Security_Team//html/Defensive_Coding/sect-Defensive_Coding-C-Libc-vsnprintf.html

Checking the return value of vasprintf in the implementation might be a good idea as well.
Comment 2 Radek Novacek 2013-08-26 13:29:53 UTC 
Fixed upstream and in the konkretcmpi-0.9.1-3.el7. Thanks for the report.