Bug 1000564

Summary: nm-connection-editor does no longer load the username/password when editing existing connection
Product: Red Hat Enterprise Linux 7 Reporter: Thomas Haller <thaller>
Component: network-manager-appletAssignee: Thomas Haller <thaller>
Status: CLOSED CURRENTRELEASE QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.0CC: dcbw, vbenes, vrutkovs
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: network-manager-applet-0.9.9.0-5.git20130906 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 09:18:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thomas Haller 2013-08-23 17:01:37 UTC 
Description of problem:

When you edit the wifi-security tab in nm-connection-editor, the username/password field is not set.


How reproducible:

Create a wifi connection, for example of type Tunneled TLS.
When you try to edit that connection again in nm-connection-editor, the username/password field is always empty.



Additional info:

This bug was introduced in upstream commit https://git.gnome.org/browse/network-manager-applet/commit/?id=c9476e9c07839e71aed49e820e364ad0b9f47039 and is in file src/wireless-security/eap-method-simple.c

Note that when editing an existing connection, the input fields will be initialized in eap_method_simple_new. But then they are unset again in widgets_realized because "method->ws_parent->username" et al. is not set to the values from the edited connection.
Comment 2 Thomas Haller 2013-08-23 19:47:31 UTC 
Patch ready for review:

https://git.gnome.org/browse/network-manager-applet/log/?h=thaller/rh1000564_wifi_security_userpass

The relevant fix is the first commit. The second commit is another unrelated feature asking for review as well :)
Comment 3 Dan Williams 2013-08-27 21:57:07 UTC 
Branch looks good, please merge, thanks!
Comment 4 Thomas Haller 2013-08-28 09:38:00 UTC 
fix merged to upstream master:

https://git.gnome.org/browse/network-manager-applet/commit/?id=3cae06120a4dd9bebd5f2e57e181ea95e87c8ac4
Comment 7 Dan Williams 2013-10-07 16:57:28 UTC 
Moving back to MODIFIED so we can attach this to a network-manager-applet errata instead of NM.
Comment 8 Vadim Rutkovsky 2014-02-25 16:09:35 UTC 
Verified on nm-connection-editor-0.9.9.0-12.git20131212.el7.x86_64
Comment 9 Ludek Smid 2014-06-13 09:18:59 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.