Bug 1000949
| Summary: | Review Request: ttfautohint - Automated hinting utility for TrueType fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | leftmostcat, notting, vietzke, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ttfautohint-0.97-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-04 06:58:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1000885 | ||
|
Description
Christopher Meng
2013-08-26 07:55:06 UTC
*** Bug 838720 has been marked as a duplicate of this bug. *** rpmlint ttfautohint: ttfautohint.x86_64: W: spelling-error %description -l en_US bytecode -> byte code, byte-code, decorate ttfautohint.x86_64: W: spelling-error %description -l en_US glyphs -> glyph, glyph s ttfautohint.x86_64: W: spelling-error %description -l en_US autohinting -> auto hinting, auto-hinting, autographing ttfautohint.x86_64: W: spelling-error %description -l en_US autohinter -> auto hinter, auto-hinter, intrauterine Please don't change autohinter to intrauterine :) ttfautohint.x86_64: W: file-not-utf8 /usr/share/doc/ttfautohint/FTL.TXT It appears to be latin1, and it's just the © symbol in the Introduction, so not crucial. But it would be nice to fix the file. ttfautohint.x86_64: W: no-manual-page-for-binary ttfautohint 1 packages and 0 specfiles checked; 0 errors, 6 warnings. % rpmlint ttfautohint-gui ttfautohint-gui.x86_64: W: spelling-error %description -l en_US bytecode -> byte code, byte-code, decorate ttfautohint-gui.x86_64: W: spelling-error %description -l en_US glyphs -> glyph, glyph s ttfautohint-gui.x86_64: W: spelling-error %description -l en_US autohinting -> auto hinting, auto-hinting, autographing ttfautohint-gui.x86_64: W: spelling-error %description -l en_US autohinter -> auto hinter, auto-hinter, intrauterine ttfautohint-gui.x86_64: W: file-not-utf8 /usr/share/doc/ttfautohint-gui/FTL.TXT ttfautohint-gui.x86_64: W: no-manual-page-for-binary ttfautohintGUI - URLs work, sources are OK ! version 0.97 is available - license is OK, files present - gnulib is bundled, which is OK. - package name is sane - Docs are 1.7MB, probably not worth splitting out. ! There's an issue that -gui has an (identical) copy of the docs. Very nice and clean package. The identical docs are needed as -gui is a dependent package which doesn't need to require main package:
%package gui
Summary: GUI for %{name} based on Qt4
For the file-not-utf8 issue, I think it can be ignored.
-----------------
Spec URL: http://cicku.me/ttfautohint.spec
SRPM URL: http://cicku.me/ttfautohint-0.97-1.fc21.src.rpm
(In reply to Christopher Meng from comment #3) > The identical docs are needed as -gui is a dependent package which doesn't > need to require main package: > > %package gui > Summary: GUI for %{name} based on Qt4 OK. But I think that the docs should not be *installed* twice. ttfautohint-gui can contain stuff in /usr/share/docs/ttfautohint, so that the user doesn't get a 1.5 MB hit on installing both. Just a suggestion. > For the file-not-utf8 issue, I think it can be ignored. OK. > ----------------- > > Spec URL: http://cicku.me/ttfautohint.spec > SRPM URL: http://cicku.me/ttfautohint-0.97-1.fc21.src.rpm Package is APPROVED. (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > (In reply to Christopher Meng from comment #3) > > The identical docs are needed as -gui is a dependent package which doesn't > > need to require main package: > > > > %package gui > > Summary: GUI for %{name} based on Qt4 > OK. But I think that the docs should not be *installed* twice. > ttfautohint-gui can contain stuff in /usr/share/docs/ttfautohint, so that > the user doesn't get a 1.5 MB hit on installing both. Just a suggestion. Any idea of using /usr/share/doc/ttfautohint but not /usr/share/doc/ttfautohint-doc for 2 packages? %files gui
-%doc AUTHORS COPYING NEWS README THANKS TODO *.TXT
-%doc doc/img doc/ttfautohint.{html,pdf,txt}
+%doc %{_pkgdocdir}/
%{_bindir}/ttfautohintGUI
Fine, thanks. New Package SCM Request ======================= Package Name: ttfautohint Short Description: Automated hinting utility for TrueType fonts Owners: cicku Branches: f19 f20 InitialCC: Git done (by process-git-requests). ttfautohint-0.97-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ttfautohint-0.97-1.fc19 ttfautohint-0.97-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ttfautohint-0.97-1.fc20 ttfautohint-0.97-1.fc19 has been pushed to the Fedora 19 testing repository. ttfautohint-0.97-1.fc19 has been pushed to the Fedora 19 stable repository. ttfautohint-0.97-1.fc20 has been pushed to the Fedora 20 stable repository. |