Bug 1000973
| Summary: | libvirtd crash when starting guest after cold-plug interface with hostdev network | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | hongming <honzhang> | ||||||
| Component: | libvirt | Assignee: | Peter Krempa <pkrempa> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 6.5 | CC: | acathrow, dyuan, honzhang, jdenemar, mjenner, mzhan, shyu, xuzhang | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | libvirt-0.10.2-24.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1002669 (view as bug list) | Environment: | |||||||
| Last Closed: | 2013-11-21 09:09:16 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1002669 | ||||||||
| Attachments: |
|
||||||||
Created attachment 790352 [details]
libvirtd debug log
Created attachment 790748 [details]
gdb backtrace
Fixed upstream:
commit 50348e6edfa10ddb61929bf95a1c4820a9614e19
Author: Peter Krempa <pkrempa>
Date: Tue Aug 27 19:06:18 2013 +0200
qemu: Remove hostdev entry when freeing the depending network entry
When using a <interface type="network"> that points to a network with
hostdev forwarding mode a hostdev alias is created for the network. This
allias is inserted into the hostdev list, but is backed with a part of
the network object that it is connected to.
When a VM is being stopped qemuProcessStop() calls
networkReleaseActualDevice() which eventually frees the memory for the
hostdev object. Afterwards when the domain definition is being freed by
virDomainDefFree() an invalid pointer is accessed by
virDomainHostdevDefFree() and may cause a crash of the daemon.
This patch removes the entry in the hostdev list before freeing the
depending memory to avoid this issue.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1000973
Verify this bug with build libvirt-0.10.2-24.el6, it is fixed. So change the bug status to "verify".
Steps:
1. prepare one health guest.
# virsh list --all
Id Name State
----------------------------------------------------
3 a running
2. prepare one hostdev network.
# virsh net-list --all
Name State Autostart Persistent
--------------------------------------------------
default active yes yes
hostnet active yes yes
# virsh net-dumpxml hostnet
<network>
<name>hostnet</name>
<uuid>6b49be3c-bb91-c16d-b475-2929678720f4</uuid>
<forward mode='hostdev' managed='yes'>
<address type='pci' domain='0x0000' bus='0x11' slot='0x10' function='0x3'/>
<address type='pci' domain='0x0000' bus='0x11' slot='0x10' function='0x2'/>
</forward>
</network>
3. check the vf on the host
# lspci|grep 82576
0e:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
0e:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
0f:10.0 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
0f:10.1 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
0f:10.2 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
0f:10.3 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
10:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
10:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
11:10.0 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
11:10.1 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
11:10.2 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
11:10.3 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01)
4. prepare one xml like the following one:
# cat vfpool.xml
<interface type='network'>
<source network='hostdev-net'/>
</interface>
5. destroy the guest, and attach the interface to the guest with config option.
# virsh destroy a
Domain a destroyed
# virsh attach-device a vfpool.xml --config
Device attached successfully
6. start the guest.
# virsh start a
Domain a started
7. make sure the libvirtd is still running
# service libvirtd status
libvirtd (pid 27668) is running...
8. check the qemu process and dumpxml, make sure the vf is attached to the guest.
# virsh dumpxml a
......
<interface type='network'>
<mac address='52:54:00:89:a4:43'/>
<source network='hostnet'/>
<alias name='hostdev0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
</interface>
......
# ps -ef|grep qemu
qemu 31330 1 24 00:29 ? 00:00:28 /usr/libexec/qemu-kvm -name a ......-device pci-assign,host=11:10.3,id=hostdev0,configfd=24,bus=pci.0,addr=0x6 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-1581.html |
Description of problem: libvirtd crash when starting guest after cold-plug interface with hostdev network Version-Release number of selected component (if applicable): libvirt-0.10.2-23.el6.x86_64 How reproducible: 100% Steps to Reproduce: # virsh start r6 Domain r6 started # virsh net-list --all Name State Autostart Persistent -------------------------------------------------- default active no yes hostdev-net1 active no yes # lspci|grep 11:10 11:10.0 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.1 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.2 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.3 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.4 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.5 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.6 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) 11:10.7 Ethernet controller: Intel Corporation 82576 Virtual Function (rev 01) # virsh net-dumpxml hostdev-net1 <network> <name>hostdev-net1</name> <uuid>c039ec41-79cd-9418-76bc-a74a7ce29715</uuid> <forward mode='hostdev' managed='yes'> <address type='pci' domain='0x0000' bus='0x11' slot='0x10' function='0x0'/> <address type='pci' domain='0x0000' bus='0x11' slot='0x10' function='0x1'/> </forward> </network> # virsh destroy r6 Domain r6 destroyed # cat vfpool.xml <interface type='network'> <source network='hostdev-net1'/> </interface> # virsh attach-device r6 vfpool.xml --config Device attached successfully # virsh start r6 error: Failed to start domain r6 error: End of file while reading data: Input/output error error: One or more references were leaked after disconnect from the hypervisor error: Failed to reconnect to the hypervisor Actual results: libvirtd crash Expected results: libvirtd works fine Additional info: