Bug 1000980
| Summary: | No error shows when the allocation of new lvm volume set as 0 | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | tingting zheng <tzheng> | |
| Component: | python-virtinst | Assignee: | Giuseppe Scrivano <gscrivan> | |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 6.5 | CC: | codong, dyuan, gscrivan, juzhou, jwildebo, lcui, mkletzan, mzhan, rbalakri, tzheng | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | python-virtinst-0.600.0-20.el6 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1021789 (view as bug list) | Environment: | ||
| Last Closed: | 2014-10-14 06:23:32 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1093980 | |||
| Bug Blocks: | 1021037, 1021789, 1024339 | |||
|
Description
tingting zheng
2013-08-26 09:00:50 UTC
Allocation 0 means that there is no setting for allocation. This might be confusing for users, but we need to keep the default value working. Can we change the default allocation to the same number as capacity in case of logical pool? Maybe make the widget disabled to disallow changing it. In any case, there should be also a check for whether the value is a number. Reproduced the bug with the following packages: # rpm -qa libvirt virt-manager virt-manager-0.9.0-19.el6.x86_64 libvirt-0.10.2-29.el6.x86_64 Create a new volume in the LVM pool Set "Allocation" as 0 or random value eg:"sdll",no error shows. Set random value eg "sdll" for volume allocation on other types of pool,no error shows. *** Bug 873976 has been marked as a duplicate of this bug. *** *** Bug 1021037 has been marked as a duplicate of this bug. *** I try to verify it with latest packages:
virt-manager-0.9.0-20.el6.x86_64
python-virtinst-0.600.0-20.el6.noarch
libvirt-0.10.2-34.el6.x86_64
but can not get clear warning/error info.
steps:
1. Create a lvm pool.
2. Launch virt-manager: #virt-manager.
3. In the lvm pool,create a new volume.Click "New Volume",set name,set "Max Capacity" as 1000 MB,
set "Allocation" as a number which is smaller than 1000,eg:10.
4. Click "Finish",got the error info:
Uncaught error validating input: Gtk.Container.add() argument 1 must be gtk.Widget, not bool
Traceback (most recent call last):
File "/usr/share/virt-manager/virtManager/createvol.py", line 211, in finish
if not self.validate():
File "/usr/share/virt-manager/virtManager/createvol.py", line 268, in validate
return self.val_err(_("Volume Parameter Error"), str(e))
File "/usr/share/virt-manager/virtManager/createvol.py", line 280, in val_err
ret = self.err.val_err(info, details, async=not modal)
File "/usr/share/virt-manager/virtManager/error.py", line 116, in val_err
self._simple_dialog(dtype, buttons, text1, text2, title, async)
File "/usr/share/virt-manager/virtManager/error.py", line 110, in _simple_dialog
sync=not async)
File "/usr/share/virt-manager/virtManager/error.py", line 40, in _launch_dialog
dialog.get_content_area().add(widget)
TypeError: Gtk.Container.add() argument 1 must be gtk.Widget, not bool
this is the same issue as new bug 1093980, so i will try to verify it again until bug 1093980 fixed.
Added depends on 1093980 Retry verify with latest build: virt-manager-0.9.0-21.el6.x86_64 python-virtinst-0.600.0-21.el6.noarch steps: 1. Create a lvm pool. 2. Launch virt-manager: #virt-manager. 3. In the lvm pool,create a new volume.Click "New Volume",set name,set "Max Capacity" as 1000 MB, set "Allocation" as a number which is smaller than 1000,eg:10. 4. Click "Finish",got the error info. "Volume Parameter Error Sparse logical volumes are not supported, allocation must be equal to capacity" 5. On step3 if set "Allocation" as 0 or random value eg:"sdll",the error shows as step4 after click "Finish" as expected. A problem found on step3. when click "New Volume",i found the default "Allocation" number is "0" not the same number with "Max Capacity"(eg:1000) . but on rhel7 the default allocation is the same number as capacity in case of logical pool. And Martin Kletzander also talked this issue on Comment 2. So Giuseppe Scrivano ,can you help have a look, thanks? from a quick check, virt-manager shows the same behavior on RHEL-7. Future versions of virt-manager will look very different anyway as it is changed upstream, so I don't think we should pay particular attention to this detail. (In reply to Giuseppe Scrivano from comment #12) > from a quick check, virt-manager shows the same behavior on RHEL-7. Future > versions of virt-manager will look very different anyway as it is changed > upstream, so I don't think we should pay particular attention to this detail. thanks for your help Giuseppe Scrivano, move to verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1444.html |