Bug 1001094

Summary:	virsh net-update reports an invalid pointer error with non-existent network
Product:	Red Hat Enterprise Linux 7	Reporter:	Ján Tomko <jtomko>
Component:	libvirt	Assignee:	Ján Tomko <jtomko>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	acathrow, dyuan, gsun, honzhang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-1.1.1-3.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-13 09:28:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Ján Tomko 2013-08-26 13:39:20 UTC

Description of problem:
virsh net-update reports an invalid pointer error with non-existent network

Version-Release number of selected component (if applicable):
libvirt-1.1.1-2.el7

How reproducible:
I'm certain that it happens all the time.

Steps to Reproduce:
1. Run virsh net-update with a non-existent network:
virsh # net-update net404 delete dns-srv '<srv service='name'/>"

Actual results:
error: failed to get network 'net404'
error: Network not found: no network with matching name 'net404'
error: invalid network pointer in virNetworkFree

Expected results:
No invalid pointer error.

Comment 1 Ján Tomko 2013-08-26 13:42:12 UTC

Upstream patch posted:
https://www.redhat.com/archives/libvir-list/2013-August/msg01301.html

Comment 3 Ján Tomko 2013-08-26 14:01:19 UTC

Now fixed upstream:
commit 784cca89c51fd13383064f248a6b375fb34e516f
Author:     Ján Tomko <jtomko>
AuthorDate: 2013-08-26 12:51:08 +0200
Commit:     Ján Tomko <jtomko>
CommitDate: 2013-08-26 15:51:15 +0200

    Don't free NULL network in cmdNetworkUpdate
    
    If the network has not been found, virNetworkFree(NULL)
    was called, resulting in an extra error:
    error: invalid network pointer in virNetworkFree
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1001094

git describe: v1.1.1-212-g784cca8

Comment 5 hongming 2013-09-02 07:46:38 UTC

Verify it using libvirt-1.1.1-3.el7.x86_64. The result is expected. Move its status to VERIFIED.


virsh # net-list
 Name                 State      Autostart     Persistent
----------------------------------------------------------
 default              active     yes           yes

virsh # net-update net404 delete dns-srv '<srv service='name'/>"
error: failed to get network 'net404'
error: Network not found: no network with matching name 'net404'

Comment 6 Ludek Smid 2014-06-13 09:28:04 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.