Bug 1001159

Summary: [rhevm] Backend - Webadmin - Cluster Properties dialog box - Disable "+" when no more keys are available
Product: Red Hat Enterprise Virtualization Manager Reporter: David Botzer <dbotzer>
Component: ovirt-engine-webadmin-portalAssignee: Noam Slomianko <nslomian>
Status: CLOSED UPSTREAM QA Contact: Lukas Svaty <lsvaty>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acathrow, dcaroest, dfediuck, ecohen, gchaplik, iheim, lpeer, mavital, pstehlik, Rhev-m-bugs, srevivo, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sla
Fixed In Version: is18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-10 06:26:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
addingProp none

Description David Botzer 2013-08-26 14:56:57 UTC
Created attachment 790558 [details]
addingProp

Description of problem:
[rhevm] Backend - Webadmin - Cluster Properties-> Cluster Policy dialog box - Disable "+" when no more keys are available

Version-Release number of selected component (if applicable):
3.3/is11

How reproducible:
always

Steps to Reproduce:
1.create new DC & Cluster
2.Edit Cluster -> Cluster Policy -> change policy to other then "None"
3.Press the "+" to add more keys

Actual results:
Adds a line with value "No Available Keys" , and it is not saved when pressing OK

Expected results:
should disable the Button, along side with "-" when there are no 
more keys available.

Additional info:
Should disabled the "-" button, when there are no 
more lines to remove (today the "-" button is enabled in this case, but does nothing).

Comment 1 Einav Cohen 2013-08-29 20:39:52 UTC
*** Bug 1002177 has been marked as a duplicate of this bug. ***

Comment 4 Noam Slomianko 2013-10-02 08:58:10 UTC
The only time the "-" button should be greyed out (except when there are no options)  is when there is only one combo box and it contains "please select a key". This is of very limited value to the user. Handling the change of selection would introduce some unpleasant code.
There is a patch handling all other aspects of the bug, I would recommend accepting it.

Please confirm that this is acceptable by you.

Comment 5 Einav Cohen 2013-10-03 01:21:02 UTC
(In reply to Noam Slomianko from comment #4)
> The only time the "-" button should be greyed out (except when there are no
> options)  is when there is only one combo box and it contains "please select
> a key". This is of very limited value to the user. Handling the change of
> selection would introduce some unpleasant code.
> There is a patch handling all other aspects of the bug, I would recommend
> accepting it.
> 
> Please confirm that this is acceptable by you.

sure, no problem (at least for 3.3).