Bug 1001410

Summary: [ALL_LANG][Admin Portal] Unlocalized string 'User: with Role: ' in 'Remove System Permission(s)' dialog.
Product: Red Hat Enterprise Virtualization Manager Reporter: Lijun Li <lijli>
Component: ovirt-engine-webadmin-portalAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Yuko Katabami <ykatabam>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.3.0CC: acathrow, bazulay, ecohen, eng-l10n-bugs, iheim, pstehlik, qe-i18n-bugs, Rhev-m-bugs, yeylon
Target Milestone: ---Keywords: CodeChange, i18n, Translation
Target Release: 3.3.0   
Hardware: x86_64   
OS: All   
Whiteboard: ux
Fixed In Version: is15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1013599 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1013599    
Attachments:
Description Flags
Unlocalized string 'User: with Role: ' in 'Remove System Permission(s)' dialog
none
code: SystemPermissionListModel.java
none
Not fixed_Remove System Permissions none

Description Lijun Li 2013-08-27 02:30:44 UTC
Description of problem:
Unlocalized string 'User: with Role: ' in 'Remove System Permission(s)' dialog.

Version-Release number of selected component (if applicable):
rhevm-3.3.0-0.16.master.el6ev.noarch.rpm
rhevm-webadmin-portal-3.3.0-0.16.master.el6ev.noarch.rpm

How reproducible:
100%

Steps to Reproduce:
1. Login web admin portal.
2. Click on the top right Configure button.
3. Click on System Permissions pane.
4. Select a user and click Remove button.


Actual results:
Unlocalized string 'User: with Role: ' in 'Remove System Permission(s)' dialog.

Expected results:
All the strings should be localized.

Additional info:
Please refer to the attached screen shot for more details.

Comment 1 Lijun Li 2013-08-27 02:32:44 UTC
Created attachment 790737 [details]
Unlocalized string 'User: with Role: ' in 'Remove System Permission(s)' dialog

Comment 2 Einav Cohen 2013-09-05 17:20:52 UTC
Created attachment 794378 [details]
code: SystemPermissionListModel.java

Comment 3 Einav Cohen 2013-09-05 17:24:16 UTC
confirming that there are hard-coded English strings in the code (see attachment 794378 [details]).

need to turn the entire sentence into a single string that accepts two variable values (i.e. "User: '{0}' with Role: '{1}'"), and make sure that this string is localized (i.e. added to "___Messages.java/.properties") in order to allow its translation.

Comment 4 Lijun Li 2013-09-27 08:08:37 UTC
Verified it NOT fixed on is15 build: 3.3.0-0.22.master.el6ev

Please see the attached screenshot.

Comment 5 Lijun Li 2013-09-27 08:09:25 UTC
Created attachment 803816 [details]
Not fixed_Remove System Permissions

Comment 6 Alexander Wels 2013-09-27 15:21:10 UTC
Einav,

Did the translation for this happen yet? if not that would explain why they are not seeing any changes.

Comment 7 Einav Cohen 2013-09-30 12:31:08 UTC
(In reply to Alexander Wels from comment #6)
> Einav,
> 
> Did the translation for this happen yet? if not that would explain why they
> are not seeing any changes.

Yes, Alex - you are right. This BZ is actually a CodeChange (updated Keywords accordingly), I am moving it to VERIFIED, as the code-change is in.

The originally reported issue should be verified in the context of the i18n BZ (bug 1013599), once it will move to ON_QA.

Comment 8 Itamar Heim 2014-01-21 22:29:40 UTC
Closing - RHEV 3.3 Released

Comment 9 Itamar Heim 2014-01-21 22:29:40 UTC
Closing - RHEV 3.3 Released

Comment 10 Itamar Heim 2014-01-21 22:32:38 UTC
Closing - RHEV 3.3 Released