Bug 1001475

Summary:	blockcommit with --delete option is not functional
Product:	Red Hat Enterprise Linux 6	Reporter:	Hao Liu <hliu>
Component:	libvirt	Assignee:	Eric Blake <eblake>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.5	CC:	acathrow, ajia, dyuan, eblake, hliu, lsu, mike, mzhan, shyu, zsong
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1008350 (view as bug list)		Environment:
Last Closed:	2014-04-04 20:57:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1008350

Description Hao Liu 2013-08-27 06:48:37 UTC

Description of problem:
blockcommit with --delete option is not functional

Version-Release number of selected component (if applicable):
Red Hat Enterprise Linux Server release 6.5 Beta
libvirt-0.10.2-23.el6.x86_64
kernel-2.6.32-414.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.398.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. prepare a guest foo.

2. blockcommit with --delete option.

# virsh blockcommit foo hda --delete
error: unsupported flags (0x2) in function qemuDomainBlockCommit

Expected result:
Successfully remove files in the backing chain or report an explicit error when not success.

Comment 2 Alex Jia 2013-08-27 07:05:43 UTC

(In reply to Hao Liu from comment #0)
> # virsh blockcommit foo hda --delete
> error: unsupported flags (0x2) in function qemuDomainBlockCommit

Need to check VIR_DOMAIN_BLOCK_COMMIT_DELETE flags, I will commit a patch to fix this.

Comment 3 Alex Jia 2013-08-27 08:05:27 UTC

Patch on upstream:
https://www.redhat.com/archives/libvir-list/2013-August/msg01333.html

Comment 4 Eric Blake 2013-08-27 12:04:56 UTC

Moving to 6.6.  The flag is a case of known future expansion, and as we're already past the feature freeze for 6.5, it isn't going to change in 6.5.

Comment 7 RHEL Program Management 2014-04-04 20:57:06 UTC

Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.