Bug 1001676

Any plans to fix this issue? I'm waiting for that to rebuild uim which depends on it.

In particular, here are (some of) the build errors:

bssh.c: In function 'main':
bssh.c:149:72: error: 'GTK_STOCK_CANCEL' undeclared (first use in this function)
             d = aui_service_dialog_new(_("Choose Shell Server"), NULL, GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, GTK_STOCK_CONNECT, GTK_RESPONSE_ACCEPT, NULL);
                                                                        ^
bssh.c:149:72: note: each undeclared identifier is reported only once for each function it appears in
bssh.c:149:111: error: 'GTK_STOCK_CONNECT' undeclared (first use in this function)
             d = aui_service_dialog_new(_("Choose Shell Server"), NULL, GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, GTK_STOCK_CONNECT, GTK_RESPONSE_ACCEPT, NULL);

avahi-ui.c:1035:57: error: 'GTK_STOCK_CANCEL' undeclared (first use in this function)
     gtk_dialog_add_button(GTK_DIALOG(p->domain_dialog), GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL);

avahi-ui.c:1167:81: error: 'GTK_STOCK_NETWORK' undeclared (first use in this function)
     gtk_button_set_image(GTK_BUTTON(p->domain_button), gtk_image_new_from_stock(GTK_STOCK_NETWORK, GTK_ICON_SIZE_BUTTON));

working on fixing the deprecations...

avahi-0.6.31-16.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/avahi-0.6.31-16.fc20

Package avahi-0.6.31-16.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing avahi-0.6.31-16.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-17264/avahi-0.6.31-16.fc20
then log in and leave karma (feedback).

I looked at the patch and it has one issue -- the new strings ("OK", "Cancel") won't be translated.

Better would be to drop the patch, and instead just kill the -Werror flag that's being set in configure.ac. (The patch would be great for upstream though, where translators could translate the new strings after commiting.)

killing -Werror isn't enough, it still fails without it.

Here's a scratch build where I tried just dropping -Werror
https://koji.fedoraproject.org/koji/taskinfo?taskID=5963926

Ah, looks like it explicitly disables deprecated gtk+ symbols with:

-DGTK_DISABLE_DEPRECATED=1

This is also something that should have never been enabled in the released tarballs. New symbols get deprecated in GTK+ from time to time -- but they're still supported and continue working fine. Deprecation just means that these symbols are going to be removed in the next major release (4.0) and that people _should_ think of porting.

Package avahi-0.6.31-18.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing avahi-0.6.31-18.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-17264/avahi-0.6.31-18.fc20
then log in and leave karma (feedback).

avahi-0.6.31-18.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Was there ever an attempt to get this fix upstream to avahi?

latest upstream is fixed as far as I can tell, fedora is no longer carrying any patches related to this

Ah, yes, it does seem to be fixed in avahi ​0.6.32-rc, but not in avahi 0.6.31, which I assumed would be the stable one to use. It's not fixed in avahi's git:
http://git.0pointer.net/avahi.git/tree/avahi-ui/Makefile.am
so I guess that the changes in avahi ​0.6.32-rc were never pushed to git. How strange.

It is officially fixed on their Github releases page.

Repository:
https://github.com/lathiat/avahi/releases

Release Information:
Feb 15, 2016
v0.6.32
4f33499

Source:
https://github.com/lathiat/avahi/releases/download/v0.6.32/avahi-0.6.32.tar.gz

SHA256Sum:
d54991185d514a0aba54ebeb408d7575b60f5818a772e28fa0e18b98bc1db454

Cheers.