Bug 1001851
| Summary: | [fr_FR][Admin Portal] Garbage string displayed in the tooltips of '#path' column name in 'Edit Domain' -> 'Targets>LUNs' pane. | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Lijun Li <lijli> |
| Component: | ovirt-engine-webadmin-portal | Assignee: | Alexander Wels <awels> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yuko Katabami <ykatabam> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.3.0 | CC: | acathrow, amureini, awels, derez, ecohen, eng-l10n-bugs, iheim, qe-i18n-bugs, Rhev-m-bugs, smaitra, yeylon |
| Target Milestone: | --- | Keywords: | i18n, Translation |
| Target Release: | 3.3.0 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | ux | ||
| Fixed In Version: | is15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-21 22:15:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Lijun Li
2013-08-28 01:08:31 UTC
Created attachment 791209 [details]
Garbage string displayed in the tooltips of '#path' column name in 'Edit Domain' -> 'Targets>LUNs' pane
' is the HTML code for a single quote, which came from the "d'acees" (In reply to Allon Mureinik from comment #2) > ' is the HTML code for a single quote, which came from the "d'acees" Indeed, looks like an issue with tool-tips rendering. The text should be HTML sanitized/escaped (e.g. using SafeHtmlUtils) when setting the title - probably around AbstractModelBoundPopupView -> setTitle(). I think the problem is not that the string is not escaped, I think the problem is that the string is double escaped. So the original "d`acees" is first escaped into "d'acees", which is then escaped again and turned into "d&#39;acees". Which is displayed as in the screen shot. Since I don't have an iSCSI capable domain, it is sort of hard for me to reproduce the issue and verify that I fixed it. I found the location where the escaping is happening, but I need some way of testing and verifying before being able to submit a patch. Upload the patch and I'll verify it. Daniel, I uploaded the patch that I *think* will fix the issue, let me know. (In reply to Alexander Wels from comment #6) > Daniel, > > I uploaded the patch that I *think* will fix the issue, let me know. Still doesn't work... I think we can just unescape (completely) tooltips text. By that, we could prevent tooltips with escaped characters/html tags (unrendered). It should be safe since browsers natively render title attributes as string. [see attached screenshots for more problematic toll-tips examples] Uploaded a new patch with the proposed solution: http://gerrit.ovirt.org/#/c/19018/2 Created attachment 796123 [details]
fr_vm_uptime_unescaped
Created attachment 796124 [details]
fr_vm_uptime_escaped
Created attachment 796125 [details]
en_vm_nics_drops_escaped
Created attachment 796126 [details]
en_vm_nics_drops_unescaped
Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released |