Bug 1002207

Summary:	remove unused parameter and correctly handle mem alloc failure
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	stripe	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1133266 (view as bug list)		Environment:
Last Closed:	2014-01-17 16:37:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1133266

Description Kaleb KEITHLEY 2013-08-28 15:42:24 UTC

Description of problem:

gf_memdup() has only a single user, namely the stripe translator. Does it warrant being in libglusterfs for just a single user?

It has an unused parameter.

The stripe xlator updates its idea of how long the xattrs are even if the memory allocation failed.


Version-Release number of selected component (if applicable):

all

How reproducible:

code examination

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-08-28 17:15:23 UTC

REVIEW: http://review.gluster.org/5716 (stripe: remove unused param, handle mem alloc failure) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Anand Avati 2013-08-28 17:35:44 UTC

REVIEW: http://review.gluster.org/5716 (stripe: remove unused param, handle mem alloc failure) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Anand Avati 2013-08-28 18:33:34 UTC

REVIEW: http://review.gluster.org/5716 (stripe: remove unused param, handle mem alloc failure) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 4 Anand Avati 2013-08-28 23:59:24 UTC

COMMIT: http://review.gluster.org/5716 committed in master by Anand Avati (avati) 
------
commit b880b6b2908ad4e4afc8e26613bd0db8f0b28750
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Wed Aug 28 22:43:41 2013 +0530

    stripe: remove unused param, handle mem alloc failure
    
    Change-Id: I9c27b1edab111031ca8eea9cc49480ea01e39089
    BUG: 1002207
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/5716
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>