Bug 1002282

Summary:	Multiple consecutive calls to virDomainFree in libvirt_domain_disk_add
Product:	[Community] Virtualization Tools	Reporter:	kory <koryekirk>
Component:	libvirt-php	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	crobinso
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-23 16:48:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description kory 2013-08-28 19:20:55 UTC

Description of problem:
on line 4322 of libvirt-php.c, in the libvirt_domain_disk_add function, there is are two consecutive calls to virDomainFree, the first freeing the domain resource, therefore causing the second call to fail always.

Version-Release number of selected component (if applicable):
commit id: 9f355ebed7a217669269c1a4016329f7411e356b

How reproducible:
Can reproduce by calling libvirt_domain_disk_add with valid parameters

Steps to Reproduce:
1. Set up libvirtd, create a domain and try to add a disk to it using libvirt_domain_disk_add
2. Observe the error message.

Actual results:
invalid connection pointer in virDomainFree

Expected results:
in libvirt-php debug log
libvirt_domain_disk_add: Domain <resource> freed
libvirt_domain_disk_add: returning 0x269a0c0


Additional info:
I have made the change of commenting out line 4322, which fixed the error

Comment 1 Cole Robinson 2016-03-23 16:48:02 UTC

I can't find the exact commit, but this issue doesn't exist upstream anymore