Bug 1002319
Summary: | Review Request: perl-Term-ShellUI - Fully-featured shell-like command line environment | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matias Kreder <delete> |
Component: | Package Review | Assignee: | Christopher Meng <i> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | i, k.georgiou, mkreder, notting, samuel-rhbugs |
Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Term-ShellUI-0.92-2.fc19 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-10-23 03:31:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1002324 |
Description
Matias Kreder
2013-08-28 21:53:08 UTC
Remove obsoleted things I've mentioned in another bug of you. New issue: I can see: BuildRequires: perl-Test-Simple in you spec. You must remind that we use this style: perl(Test::Simple) Furthermore, let's look at perl-Test-Simple itself. Its Provides: perl(Test::Builder) = 0.98 perl(Test::Builder::IO::Scalar) = 2.110 perl(Test::Builder::Module) = 0.98 perl(Test::Builder::Tester) = 1.23 perl(Test::Builder::Tester::Color) = 1.23 perl(Test::Builder::Tester::Tie) perl(Test::More) = 0.98 perl(Test::Simple) = 0.98 perl-Test-Simple = 0.98.05-3.fc20 perl-Test-Simple-tests = 0.98.05-3.fc20 I have uploaded a new .spec and .srpm file. Spec: http://fedorapeople.org/~delete/kpcli/perl-Term-ShellUI.spec SRPM: http://fedorapeople.org/~delete/kpcli/perl-Term-ShellUI-0.92-2.fc20.src.rpm Please let me know if there is anything else you see wrong. From the spec I think is good now, however I can't sponsor you so I have to stop here. Suggestion: When the sponsor ask you to change something, please sort %install : make pure_install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; %{_fixperms} $RPM_BUILD_ROOT/* Don't leave too many blank lines. > Don't leave too many blank lines. Style (and also ordering of tags) inside the spec file is up to the package maintainer. We don't force packagers to adapt to some mandatory style and not to the available spec templates either. [...] > Fully-featured I think it's "full-featured" or "fully featured". Other than that, I think both %summary and %description don't make clear that this is just a Perl module to develop with and no ready-to-use executable. Even the first sentence of the description is misleading/ambiguous, IMO. > Summary: Fully-featured shell-like command line environment > %description > Term::ShellUI uses the history and autocompletion features of > Term::ReadLine to present a sophisticated command-line interface to the > user. It tries to make every feature that one would expect to see in a > fully interactive shell trivial to implement. You simply declare your > command set and let ShellUI take care of the heavy lifting. Any ideas how to improve it? Summary: Full-featured shell-like command line environment API Or to copy from the description: Summary: Make it easy to implement a full-featured shell-like command line environment Summary: Perl module to implement a full-featured shell-like command line environment The %description could simply be reordered to do a better job: %description Term::ShellUI is a Perl module, which tries to make every feature that one would expect to see in a fully interactive shell trivial to implement. It uses the history and autocompletion features of Term::ReadLine to present a sophisticated command-line interface to the user. You simply declare your command set and let ShellUI take care of the heavy lifting. [...] Just my point of view. Anyone search for a "shell" would see this package in the search results. Thank you all for the suggestions, I agree that the .spec file looks better without the white lines. Regarding the description and summary, I just had left what the author had uploaded to cpan.org, but it is more clear if we implement your suggestion. I've re-uploaded the .spec file and the src.rpm to the same location. Spec: http://fedorapeople.org/~delete/kpcli/perl-Term-ShellUI.spec SRPM: http://fedorapeople.org/~delete/kpcli/perl-Term-ShellUI-0.92-2.fc20.src.rpm I no longer need sponsorship but this package needs a reviewer. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Text(perl-Text-ParseWords, perl-Text-Diff, perl-Text-Glob, perl-Text-FindIndent, perl-Text-Autoformat, perl-Text- Unidecode, perl-Text-Reform), /usr/share/perl5/vendor_perl/Term(perl- Term-UI) $ rpm -qlp ../RPMS/noarch/perl-Term-ShellUI-0.92-2.fc21.noarch.rpm /usr/share/doc/perl-Term-ShellUI /usr/share/doc/perl-Term-ShellUI/Changes /usr/share/doc/perl-Term-ShellUI/README /usr/share/man/man3/Term::ShellUI.3pm.gz /usr/share/man/man3/Text::Shellwords::Cursor.3pm.gz /usr/share/perl5/vendor_perl/Term /usr/share/perl5/vendor_perl/Term/ShellUI.pm /usr/share/perl5/vendor_perl/Text /usr/share/perl5/vendor_perl/Text/Shellwords /usr/share/perl5/vendor_perl/Text/Shellwords/Cursor.pm I can edit the .spec to package only the .pm files that this packages provide as this: %{perl_vendorlib}/Term/* %{perl_vendorlib}/Text/* But what would happen if %{perl_vendorlib}/Term or %{perl_vendorlib}/Text directories are not created because they are owned by one of these packages and they are not installed. Add one of them as a dependency might not be correct as they might not be required by the user. I red the Wiki page several times and trying to match some of the examples to this case I only get to the conclusion that this package should also own these directories. Based on the rule of thumb described there, I believe that none of the other packages that own this directory should be required as they don't need to be present for the primary functionality of this package. If you disagree please let me know and I will fix it. Michael, any suggestions? What answer do you hope for? Matias' conclusion in comment 10 is entirely correct. It's exactly the reason why that section of the packaging guidelines exists. OK. APPROVED. New Package SCM Request ======================= Package Name: perl-Term-ShellUI Short Description: Perl module to implement a full-featured shell-like command line environment Owners: delete echevemaster Branches: f18 f19 f20 el5 el6 InitialCC: New Package SCM Request ======================= Package Name: perl-Term-ShellUI Short Description: Perl module to implement a full-featured shell-like command line environment Owners: delete echevemaster Branches: f18 f19 f20 el5 el6 InitialCC: perl-sig I forget to CC perl-sig Git done (by process-git-requests). perl-Term-ShellUI-0.92-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Term-ShellUI-0.92-2.fc18 perl-Term-ShellUI-0.92-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Term-ShellUI-0.92-2.fc19 perl-Term-ShellUI-0.92-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Term-ShellUI-0.92-2.fc20 perl-Term-ShellUI-0.92-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Term-ShellUI-0.92-2.el6 perl-Term-ShellUI-0.92-2.fc19 has been pushed to the Fedora 19 testing repository. *** Bug 1018871 has been marked as a duplicate of this bug. *** perl-Term-ShellUI-0.92-2.fc19 has been pushed to the Fedora 19 stable repository. perl-Term-ShellUI-0.92-2.fc18 has been pushed to the Fedora 18 stable repository. perl-Term-ShellUI-0.92-2.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Term-ShellUI-0.92-2.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: perl-Term-ShellUI New Branches: epel7 Owners: delete Git done (by process-git-requests). |