Bug 1002342
| Summary: | redhat-lsb-core pulls in the graphical stack due to cups | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Baker <sbaker> | ||||||||
| Component: | cups | Assignee: | Tim Waugh <twaugh> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 19 | CC: | hliu, jpopelka, ovasik, pnemade, tools-bugs, twaugh | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | cups-1.7.1-9.fc21 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-04-02 15:44:14 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1115057 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Steve Baker
2013-08-29 00:02:08 UTC
Created attachment 791554 [details]
dot -Tsvg -o redhat-lsb-core.svg < redhat-lsb-core.dot
Sounds strange. I don't see explicit cups requirement in redhat-lsb-core of f19 - http://koji.fedoraproject.org/koji/rpminfo?rpmID=4020867 and http://koji.fedoraproject.org/koji/rpminfo?rpmID=4020866 ... it would be really good to find out what dependency brings it in. I see, /usr/bin/lp and /usr/bin/lpr explicit binary requirement. Adding Tim Waugh to cc - Tim, are you aware of any reason why these have to be in the lsb-core instead of the printing module ? Hmmms, I see... /usr/bin/lpr is required binary in the core specification. Can we have the core cups binaries in some subpackage? Otherwise, the graphical stack will likely stay in dependency tree - I have to require /usr/bin/lpr in -core. Potentially the CUPS client binaries could be in a sub-package. Created attachment 879123 [details]
cups-client.patch
How does this spec file change look?
Comment on attachment 879123 [details] cups-client.patch Looks good to me. I'd just make the Requires arch-specific, i.e. Requires: %{name}-client%{?_isa} = %{epoch}:%{version}-%{release} We miss it also in '%package lpd', so could you do [1] - Requires: %{name} = %{epoch}:%{version}-%{release} + Requires: %{name}%{?_isa} = %{epoch}:%{version}-%{release} when you are in it ? [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package Actually it won't be that easy I think - we use alternatives for these binaries. Shouldn't the installing of alternatives be moved from %post to '%post client' ? Moved to cups, as the package split will happen there (with no change in redhat-lsb-core) (In reply to Jiri Popelka from comment #8) > Actually it won't be that easy I think - we use alternatives for these > binaries. > Shouldn't the installing of alternatives be moved from %post to '%post > client' ? Oh, you're right, thanks for spotting that. Luckily all of the 'alternatives' commands will move to the sub-package, so we can just move the alternatives handling to the client sub-packages. Let's make those changes, along with the {?_isa} addition and the lpd sub-package fix. Should be fixed in cups-1.7.1-9.fc21 http://pkgs.fedoraproject.org/cgit/cups.git/commit/?id=7d8f9987c26661757aa8b4e27a3badb273a37e27 |