Bug 1002443

Summary: filtering with non existing plugin returns empty list
Product: Red Hat Enterprise Virtualization Manager Reporter: Laszlo Hornyak <lhornyak>
Component: ovirt-scheduler-proxyAssignee: Doron Fediuck <dfediuck>
Status: CLOSED DUPLICATE QA Contact: Artyom <alukiano>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acathrow, dfediuck, iheim, jmoskovc, mavital, srevivo
Target Milestone: ---Keywords: Triaged
Target Release: 3.3.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sla
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-22 11:55:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1078909, 1142926    

Description Laszlo Hornyak 2013-08-29 08:36:01 UTC
Description of problem:
filtering with non existing plugin returns empty list

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. call filter with a plugin that does not exist
2. get the result

Actual results:
empty list

Expected results:
exception

Additional info:

Comment 1 Laszlo Hornyak 2013-09-02 11:21:21 UTC
proxy part merged c9773f898698f2b84b47e3410a4357698cb66b6c

Comment 5 Artyom 2013-11-28 15:24:38 UTC
Verified on is25, no exception in engine.log

Comment 6 Artyom 2013-12-05 14:54:05 UTC
After discussion with Doron and Martin revealed that, if filter is corrupted or missing external scheduler must return all hosts and vm must run.

Comment 7 Artyom 2013-12-06 06:56:25 UTC
Checked on is26,
Can't run vm, when corrupted filter function is added to ovirt-sheduler-proxy
engine.log:
Cant find VDS to run the VM 687e60b6-5632-4c97-80c1-23a63f61c550 on, so this VM will not be run

ovirt-sheduler-proxy.log
Fri, 06 Dec 2013 08:53:55 DEBUG    [process:MainProcess, thread:Thread-7] [Request:2c9637ac-5e43-11e3-9f2b-001a4a1697fa][Method:run_filters] - Waiting for filters to finish
Fri, 06 Dec 2013 08:53:55 ERROR    [process:MainProcess, thread:Thread-8] [Request:2c9637ac-5e43-11e3-9f2b-001a4a1697fa][Method:PythonMethodRunner] - script ['python', '-c', "import max_vm_filter; max_vm_filter.max_vms().do_filter(['1ab5d0d9-5f2d-4994-8f6e-773870b1d1a0'], '687e60b6-5632-4c97-80c1-23a63f61c550', {})"] got error Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named max_vm_filter

Fri, 06 Dec 2013 08:53:55 DEBUG    [process:MainProcess, thread:Thread-7] [Request:2c9637ac-5e43-11e3-9f2b-001a4a1697fa][Method:run_filters] - Aggregating results
Fri, 06 Dec 2013 08:53:55 WARNING  [process:MainProcess, thread:Thread-7] Error in ['python', '-c', "import max_vm_filter; max_vm_filter.max_vms().do_filter(['1ab5d0d9-5f2d-4994-8f6e-773870b1d1a0'], '687e60b6-5632-4c97-80c1-23a63f61c550', {})"] (errno: 1, errors: Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named max_vm_filter
)
Fri, 06 Dec 2013 08:53:55 INFO     [process:MainProcess, thread:Thread-7] [Request:2c9637ac-5e43-11e3-9f2b-001a4a1697fa][Method:run_filters] - returning: []
So if module not exist on rhevm but exist in db, run vms is failed

Comment 10 Jiri Moskovcak 2014-01-22 11:55:41 UTC

*** This bug has been marked as a duplicate of bug 1002444 ***

Comment 11 Artyom 2014-01-22 12:26:31 UTC
Not sure that it's duplicate bugs, because you have different conditions and also different reproduce steps

Comment 12 Doron Fediuck 2014-02-10 13:54:31 UTC
(In reply to Artyom from comment #11)
> Not sure that it's duplicate bugs, because you have different conditions and
> also different reproduce steps

It's a nuance on what causes an empty list using the same backing code.
Not worth monitoring and testing twice since we unify these scenarios now.