| Summary: | [nmcli] editor should allow entering MAC addresses also in dashed format | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vitezslav Humpa <vhumpa> | ||||
| Component: | NetworkManager | Assignee: | Jirka Klimes <jklimes> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Desktop QE <desktop-qa-list> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 7.0 | CC: | dcbw, pvine, rkhan | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | NetworkManager-0.9.9.0-10.git20130906 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-06-13 10:39:55 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Vitezslav Humpa
2013-08-29 12:47:19 UTC
Sounds like a quick win. Since the standard library functions like ether_aton() don't handle "-" nmcli would probably just quickly search/replace "-" to ":" if the first attempt at ether_aton() failed. Created attachment 792164 [details] [PATCH] util: allow hyphens in MAC notation - nm_utils_hwaddr_aton_len() The patch allows accepting hyphens (-) in MAC address string representation in nm_utils_hwaddr_aton(_len) function. nmcli uses the functions, so both 'add' and 'edit' nmcli commands will accept such MACs. > Sounds like a quick win. Since the standard library functions like ether_aton() don't handle "-" nmcli would probably just quickly search/replace "-" to ":" if the first attempt at ether_aton() failed. Actually, nmcli doesn't use ether_aton() any more. Instead, it makes use of libnm-util nm_utils_hwaddr_aton() and nm_utils_hwaddr_atoba() functions. So I updated the libnm-util's code. ether_aton() is used on several places in NM, mainly for reading MAC from ifcfg. I'm not sure if we want to allow hyphens there too. Also pushed to jklimes/rh1002553-mac-hyphens NM upstream branch. Branch looks good, please merge. THanks! 0e57603e4375ca77cb3c3987865e0293706172c8 (master) This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request. |