| Summary: | rhevm-setup uninstalls rhevm on failure if user chose to continue with inability to rollback | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Tim Hildred <thildred> | ||||||
| Component: | ovirt-engine-setup | Assignee: | Alon Bar-Lev <alonbl> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | sefi litmanovich <slitmano> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 3.2.0 | CC: | acathrow, alonbl, bazulay, dougsland, iheim, oschreib, rhev-integ, Rhev-m-bugs, yeylon | ||||||
| Target Milestone: | --- | Keywords: | ZStream | ||||||
| Target Release: | 3.3.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | integration | ||||||||
| Fixed In Version: | is14 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | Bug | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1007554 | ||||||||
| Attachments: |
|
||||||||
Hi Tim,
I will love to get: /var/log/ovirt-engine/setup/ovirt-engine-setup-20130830140120.log, as I do want to understand why postgresql connection did not succeed, I hope there will be more information in the log.
For the packages...
Setup will not be able to rollback new packages in case of a failure, because installed ones were not found in enabled repositories.
Do you want to abort Setup? (Yes, No) [Yes]: No
As it tries to rollback transaction, it erases the new packages but unable to install the previous ones.
Difficult one.
Should we leave the upgraded packages that are incompatible? Should we not allow continue if rollback is missing? Or should we attempt to rollback as much as possible?
(In reply to Alon Bar-Lev from comment #1) > Hi Tim, > > I will love to get: > /var/log/ovirt-engine/setup/ovirt-engine-setup-20130830140120.log, as I do > want to understand why postgresql connection did not succeed, I hope there > will be more information in the log. Ok, I'll add an attachment > As it tries to rollback transaction, it erases the new packages but unable > to install the previous ones. > > Difficult one. > > Should we leave the upgraded packages that are incompatible? Should we not > allow continue if rollback is missing? Or should we attempt to rollback as > much as possible? What about a message that says "An error during database creation interrupted rhevm-setup (is the postgresql service already running?). Correct the error, and run the rhevm-setup script again." Or alternatively: "rhevm-setup failed due to an error. Would you like to remove the updates you already downloaded? Yes or No [No]: Yes WARNING, this may remove your previously installed Red Hat Enterprise Virtualization Manager packages. Are you sure you want to continue? Yes or No [No]:" Created attachment 792710 [details]
requested log file.
commit 54c67f91ad7cb3880812fb89834d273fd2cc42e4
Author: Alon Bar-Lev <alonbl>
Date: Sun Sep 8 00:43:07 2013 +0300
packaging: setup: disable yum transaction rollback if no rollback is available
rhel yum does not downgrade on rollback but erase and install, this
cause packages that cannot be rollbacked to be actually erased.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002804
Change-Id: Ie3f868a84453e6e58de173e57a280fc51b5e9dd1
Signed-off-by: Alon Bar-Lev <alonbl>
Itamar, I suggest to have this also in 3.2.z This bug has been cloned to bug #1007554 QA note (RHEL only):
1. Prepare environment in which 3.2/3.1 are installed.
2. Disable the channel of current version.
3. Edit engine-upgrade.py, modify the following to ensure failure:
# yum update
runFunc(upgradeFunc, MSG_INFO_YUM_UPDATE)
+ raise RuntimeExcpetion('TESTING')
# check if update is relevant to db update
if updateRelatedToDB:
4. Run engine-upgrade, notice the 'unable to rollback' warning, and choose to continue.
5. After error the new packages that were installed/updated should be kept.
Verified according to the above mentioned flow. Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released |
Created attachment 792008 [details] rhevm gets completely uninstalled after failed rhevm-setup. Description of problem: I was messing around with manually configured db, and had the postgresql service running when I ran rhevm-setup. rhevm-setup discovered that there were new packages, and asked if I wanted to download them. I said yes. rhevm-setup downloaded the new packages, verified them, and proceeded into the installation. I selected automatic db setup. rhevm-setup discovered couldn't start and connect to postgres service, because it was already running. rhevm-setup did a yum-rollback (even though it had warned me previously that yum-rollback would not be possible) on the packages it tried to update, which actually uninstalled all of the rhevm packages. rhevm-setup should not result in your packages being removed.