Bug 1003079

Summary: Candlepin will not autosubscribe to a pool with an unlimited quantity.
Product: [Retired] Subscription Asset Manager Reporter: Michael Stead <mstead>
Component: candlepinAssignee: Michael Stead <mstead>
Status: CLOSED CURRENTRELEASE QA Contact: Garik Khachikyan <gkhachik>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.3CC: bkearney, gkhachik, mkoci, mstead, omaciel, tomckay
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-07 16:45:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 971511    
Attachments:
Description Flags
step1
none
step2
none
step3 none

Description Michael Stead 2013-08-30 17:40:56 UTC 
Description of problem:

Candlepin will not autosubscribe to a pool with an unlimited quantity.

Version-Release number of selected component (if applicable):


How reproducible:
Always

NOTE: This has nothing to do with data center subscriptions, but using candlepin's data center test data is the easist way to reproduce.

Steps to Reproduce:
1. Register host consumer and consume subscription "Awesome OS Server Basic (data center)" only. This will create a virtual pool with an unlimited quantity. This bonus pool will have an SLA of "Full-Service".
2. Run "sudo virt-who -d -o" to associte the guest.
3. Ensure that only the "37060.pem" product is installed on the guest.
4. Register a guest consumer in the subscription-manager GUI -- allow autosubscribe on register.
5. When the service level selector is displayed, notice that "Full-Service" is not listed, even though the pool would satisfy compliance.

Actual results:
When the service level selector is displayed, notice that "Full-Service" is not listed, even though the bonus pool would satisfy the system.

Expected results:
Full-Service SLA should be in the SLA list since the associated pool will cover the guest system. Selecting this SLA should show the bonus pool in the next dialog -- Awesome OS Server Basic (dc-virt)

Additional info:
This is because there is an error in how candlepin's rules are filtering pools when determining best_pools. A check for unlimited quantity was missing.
Comment 1 Michael Stead 2013-08-30 18:04:53 UTC 
Pull Request submitted for review:

https://github.com/candlepin/candlepin/pull/363
Comment 2 Michael Stead 2013-09-03 13:28:30 UTC 
Fixed by commit https://github.com/candlepin/candlepin/commit/af01ac7a98ab24d589fda339d75a84552fad31ca

Available in master branch, and will be available in candlepin-0.8.25-1
Comment 4 Garik Khachikyan 2013-09-25 10:53:02 UTC 
nm, seems i found an SKU to use (with unlimited guests and Premium support type).
Comment 5 Garik Khachikyan 2013-09-25 12:16:43 UTC 
# REOPEN

doing UI registration of the virtual guest it (still) consumes the physical pool of the SKU.

scenario:
1. generate manifest from "Red Hat Enterprise Linux Advanced Platform, Premium (unlimited sockets)"
2. import manifest to the SAM latest.
3. register and autosubscribe the host.
4. run virt-who (it reports the guests recently prepared)
5. configure the guest having Gnome there.
6. via RHSM GUI perform steps above (see screenshots attached).
7. result: the guest gets subscribed to the physical pool (but should be chosen the virt. pool instead). NOTE: cli registration with --autosubscribed works perfectly - virtual pool gets chosen.

versions: 
RHSM packages:
====
subscription-manager-1.1.23-1.el6.x86_64
subscription-manager-gui-1.1.23-1.el6.x86_64
subscription-manager-firstboot-1.1.23-1.el6.x86_64
python-rhsm-1.1.8-1.el6.x86_64
====

SAM 1.3
====
candlepin-0.8.26-1.el6sam.noarch
candlepin-cert-consumer-hephaestus.usersys.redhat.com-1.0-1.noarch
candlepin-scl-1-5.el6_4.noarch
candlepin-scl-quartz-2.1.5-5.el6_4.noarch
candlepin-scl-rhino-1.7R3-1.el6_4.noarch
candlepin-scl-runtime-1-5.el6_4.noarch
candlepin-selinux-0.8.26-1.el6sam.noarch
candlepin-tomcat6-0.8.26-1.el6sam.noarch
elasticsearch-0.19.9-8.el6sat.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
katello-certs-tools-1.4.2-2.el6sat.noarch
katello-cli-1.4.3-11.el6sat.noarch
katello-cli-common-1.4.3-11.el6sat.noarch
katello-common-1.4.3-15.el6sam_splice.noarch
katello-configure-1.4.4-4.el6sat.noarch
katello-glue-candlepin-1.4.3-15.el6sam_splice.noarch
katello-glue-elasticsearch-1.4.3-15.el6sam_splice.noarch
katello-headpin-1.4.3-15.el6sam_splice.noarch
katello-headpin-all-1.4.3-15.el6sam_splice.noarch
katello-selinux-1.4.4-2.el6sat.noarch
ruby193-rubygem-ldap_fluff-0.2.2-1.el6sat.noarch
thumbslug-0.0.34-1.el6sam.noarch
thumbslug-selinux-0.0.34-1.el6sam.noarch
====

(screenshots attaching now...)
Comment 6 Garik Khachikyan 2013-09-25 12:17:51 UTC 
Created attachment 802762 [details]
step1
Comment 7 Garik Khachikyan 2013-09-25 12:18:28 UTC 
Created attachment 802764 [details]
step2
Comment 8 Garik Khachikyan 2013-09-25 12:18:58 UTC 
Created attachment 802765 [details]
step3
Comment 9 Carter Kozak 2014-03-06 16:27:54 UTC 
This should be fixed in the latest candlepin/sam.
Comment 10 Bryan Kearney 2014-11-07 16:45:59 UTC 
Closing out old bugs. If you are still having an issue, please feel free to re-open.