Bug 1003184

Summary:	EL5 package missing %_sharedstatedir macro
Product:	[Community] GlusterFS	Reporter:	Joe Julian <joe>
Component:	build	Assignee:	GlusterFS Bugs list <gluster-bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.3.2	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-17 11:46:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Joe Julian 2013-08-31 15:36:15 UTC

Description of problem:

The package creates directory /usr/com/glusterd however this does not otherwise exist in RHEL5.

Version-Release number of selected component (if applicable):
glusterfs-3.3.2-2.el5

How reproducible:
Always

Steps to Reproduce:
1. Install the package
2. type "ls /usr/com"
3.
  
Actual results:
It exists.

Expected results:
It shouldn't exist.

Additional info:

This can be fixed by adding the following line to the spec file:

%define _sharedstatedir /var/lib

Comment 1 Anand Avati 2013-10-09 04:33:42 UTC

REVIEW: http://review.gluster.org/6054 (glusterfs.spec: Add _sharedstatedir) posted (#1) for review on master by Harshavardhana (harsha)

Comment 2 Anand Avati 2013-10-09 21:59:16 UTC

REVIEW: http://review.gluster.org/6054 (glusterfs.spec: Add _sharedstatedir for RHEL5) posted (#2) for review on master by Harshavardhana (harsha)

Comment 3 Anand Avati 2013-10-09 22:04:51 UTC

REVIEW: http://review.gluster.org/6054 (glusterfs.spec: Add _sharedstatedir for RHEL5) posted (#3) for review on master by Harshavardhana (harsha)

Comment 4 Anand Avati 2013-10-10 11:21:17 UTC

REVIEW: http://review.gluster.org/6054 (glusterfs.spec: Add _sharedstatedir for RHEL5) posted (#4) for review on master by Harshavardhana (harsha)

Comment 5 Anand Avati 2013-10-11 21:12:34 UTC

REVIEW: http://review.gluster.org/6054 (glusterfs.spec: Add _sharedstatedir for RHEL5) posted (#5) for review on master by Harshavardhana (harsha)

Comment 6 Anand Avati 2013-10-12 07:41:26 UTC

COMMIT: http://review.gluster.org/6054 committed in master by Anand Avati (avati) 
------
commit 46302d0f008c312f13cf780290cbb3e6a0a83b9d
Author: Harshavardhana <harsha>
Date:   Tue Oct 8 21:30:21 2013 -0700

    glusterfs.spec: Add _sharedstatedir for RHEL5
    
    -------------------------------------------------
    > # rpm --showrc | grep sharedstatedir | grep com
    -14: _sharedstatedir %{_prefix}/com
    > # cat /etc/redhat-release
    Red Hat Enterprise Linux Server release 5.8 (Tikanga)
    -------------------------------------------------
    
    EL5 package has a missing macro _sharedstatedir which
    should be pointing to `/var/lib` not `%{_prefix}/com`
    
    Change-Id: Ida72360d73d5dffa767c69642ee395e9c82fa8c6
    BUG: 1003184
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/6054
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 7 Anand Avati 2013-10-17 18:05:11 UTC

REVIEW: http://review.gluster.org/6105 (glusterfs.spec.in: bad %define _sharedstatedir for rhel5) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 8 Anand Avati 2013-10-17 21:11:23 UTC

COMMIT: http://review.gluster.org/6105 committed in master by Anand Avati (avati) 
------
commit 9a31a25cfa3d8a4355412e2fff93482bb7352a52
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Oct 17 14:03:21 2013 -0400

    glusterfs.spec.in: bad %define _sharedstatedir for rhel5
    
    Change-Id: If2ca7052dfce9fada42180f1d469316fcde5adcb
    BUG: 1003184
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/6105
    Reviewed-by: Justin Clift <jclift>
    Tested-by: Justin Clift <jclift>
    Tested-by: Gluster Build System <jenkins.com>

Comment 9 Niels de Vos 2014-04-17 11:46:56 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user