Bug 1003266

Summary: [engine-webadmin] uninformative error on UI when remove ISO domain with format fails due to VDSNetworkException
Product: Red Hat Enterprise Virtualization Manager Reporter: Elad <ebenahar>
Component: ovirt-engine-webadmin-portalAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acanan, amureini, ebenahar, ecohen, iheim, mlipchuk, rbalakri, Rhev-m-bugs, scohen, tnisan, yeylon
Target Milestone: ---Flags: tnisan: Triaged+
Target Release: 3.5.0   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: org.ovirt.engine-root-3.5.0-15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1156162    
Attachments:
Description Flags
logs and screenshot
none
engine.log none

Description Elad 2013-09-01 11:53:34 UTC
Created attachment 792589 [details]
logs and screenshot

Description of problem:
When RemoveStorageDomainCommand with format=true (on ISO domain) fails due to VDSNetworkException, engine reports on UI this error:
"Error while executing action Remove Storage Domain: Internal Engine Error"

This massage is not informative enough, engine should report about the real problem, which is the connectivity issue with vdsm.

on engine.log we get this:

2013-09-01 14:35:57,418 ERROR [org.ovirt.engine.core.bll.storage.ConnectStorageToVdsCommand] (ajp-/127.0.0.1:8702-6) Command org.ovirt.engine.core.bll.storage.ConnectStorageToVdsCommand throw Vdc Bll exception. Wi
th error message VdcBLLException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException: java.net.SocketException: Connection reset (Failed with error VDS_NETWORK_ERROR and code 5022)


Version-Release number of selected component (if applicable):
rhevm-3.3.0-0.16.master.el6ev.noarch
rhevm-webadmin-portal-3.3.0-0.16.master.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. have an ISO domain and detach it from DC
2. remove the domain with format, and restart vdsm during the action

Actual results:
Engine fails to send the RemoveStorageDomainCommand to vdsm and We get the mentioned error on UI

Expected results:
engine should report about the real problem, which is the connectivity issue with vdsm.

Additional info: logs and screenshot

Comment 1 Maor 2013-09-02 11:18:50 UTC
Engine should only print an audit log which indicates there was a failure removing the storage domain

Comment 2 Maor 2013-09-02 12:27:30 UTC
The error should seep through the storage helpers to the remove Storage Domain Command.
Right now the storage helpers only return boolean value and therefore the indication of the error get lost from that point beyond.

Comment 4 Eyal Edri 2014-10-07 07:12:45 UTC
this bug status was moved to MODIFIED before engine vt5 was built,
hence moving to on_qa, if this was mistake and the fix isn't in,
please contact rhev-integ

Comment 5 Elad 2014-10-14 08:18:40 UTC
Created attachment 946725 [details]
engine.log

Still getting "Error while executing action Remove Storage Domain: Internal Engine Error" when I try to remove an ISO domain with format while VDSM cannot access the storage.

Used rhev3.5 vt5

Re-openning 

Attaching the logs

Comment 6 Tal Nisan 2014-10-15 08:31:52 UTC
Did you try to reproduce with the exact steps to reproduce? Because it might be a different error than VDS_NETWORK_ERROR

Comment 7 Tal Nisan 2014-10-15 08:45:05 UTC
After discussing with eedri, it seems that this fix did not make it into vt5, moving to modified and it will be featured in the next version

Comment 8 Elad 2014-10-21 10:07:36 UTC
(In reply to Tal Nisan from comment #7)
> After discussing with eedri, it seems that this fix did not make it into
> vt5, moving to modified and it will be featured in the next version

Will test it in the next build

Comment 9 Elad 2014-10-22 12:09:53 UTC
The error message thrown is informative and not generic when ISO domain format fails due to connection loss:

"Error while executing action Remove Storage Domain: Problem while trying to mount target"


Verified using rhev3.5 vt6

Comment 10 Allon Mureinik 2015-02-16 19:12:41 UTC
RHEV-M 3.5.0 has been released, closing this bug.

Comment 11 Allon Mureinik 2015-02-16 19:12:42 UTC
RHEV-M 3.5.0 has been released, closing this bug.