Bug 1003270

Summary:	openstack-foreman-installer: The values 'PUBLIC/PRIVATE_NETMASK' in foreman_server.sh are actually being used for 'floating/fixed_network_range'.
Product:	Red Hat OpenStack	Reporter:	Omri Hochman <ohochman>
Component:	openstack-foreman-installer	Assignee:	Jason Guiditta <jguiditt>
Status:	CLOSED NOTABUG	QA Contact:	Omri Hochman <ohochman>
Severity:	low	Docs Contact:
Priority:	low
Version:	3.0	CC:	hateya, morazi, rhos-maint, yeylon
Target Milestone:	---
Target Release:	4.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-25 22:08:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Omri Hochman 2013-09-01 13:05:30 UTC

openstack-foreman-installer: The values 'PUBLIC/PRIVATE_NETMASK' in foreman_server.sh are actually being used for 'floating/fixed_network_range'.


Environment: 
-------------
RHOS3.0.z-2 (puddle 2013-08-27.1)
ruby193-openstack-foreman-installer-0.0.18-3.el6ost.x86_64

Description :
--------------
the values : 'PUBLIC_NETMASK' and 'PRIVATE_NETMASK'  are being used as 'floating_network_range' and 'fixed_network_range' (parameters of 'compute' hostGroup)  - the parameters in the script should be renamed according their propose.

In this case:
--------------
PUBLIC_NETMASK / PRIVATE_NETMASK in foreman_server.sh - should be called fixed_network_range and floating_network_range.

Comment 1 Jason Guiditta 2013-11-15 16:52:49 UTC

This is as it was from rhos3, no change in name.  Really, I don't think it is worth changing, as we already have documentation explaining what it is for, and in the future, this environment variable will be going away altogether anyway