Bug 1003551

Summary: Links to Form Modeler should be disabled in BRMS UI (Guvnor)
Product: [Retired] JBoss BRMS Platform 6 Reporter: Jan Hrcek <jhrcek>
Component: Business CentralAssignee: Pere Fernàndez <pere.fernandez>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Hrcek <jhrcek>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0.0CC: atangrin, rzhang, tsurdilo
Target Milestone: ER4   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:20:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Unwanted link to form modeler 1
none
Unwanted link to form modeler 2 none

Description Jan Hrcek 2013-09-02 10:59:14 UTC
Created attachment 792794 [details]
Unwanted link to form modeler 1

Description of problem:
There are 2 places in BRMS UI (Guvnor) that link to Form Modeler tool, which is not available in BRMS product. These links should be disabled, because they cause iframe with HTTP 404 error to be opened. The 2 places are:
1) In New Item menu > New Form
2) In designer's toolbar > form menu

Version-Release number of selected component (if applicable):
BRMS 6.0.0.ER2

How reproducible:
Always

Steps to Reproduce:
1. Deploy BRMS product ont EAP 6.1.0 (with demo projects enabled)
2. Login to http://localhost:8080/business-central

1)
3. Navigate to Authoring > Projects
4. select 'New Item' - > New Form and try to create new form

2)
5. Create new process - this opens designer.
6. In Designer click menu with form icon and then click either 'Edit process form' or 'Edit task form' (requires some Manual Task node to be selected)

Actual results:
The 'New Item' (from step 4.) as well as 2 menu items in designer (from step 6.) open new form modeler iframe with HTTP 404 error

Expected results:
The links to form modeler should be removed. In case of designer probably whole 'Form' menu should be removed for BRMS product.

Comment 1 Jan Hrcek 2013-09-02 10:59:49 UTC
Created attachment 792795 [details]
Unwanted link to form modeler 2

Comment 2 Pere Fernàndez 2013-09-03 17:00:10 UTC
The servlet configuration of form-modeler component was missing. I added it and it's working.

Commits:
https://github.com/droolsjbpm/kie-wb-distributions/commit/01d17fa609d1b96433834731035912856644c2cd

Comment 3 Jan Hrcek 2013-09-24 12:10:27 UTC
Hello Pere.

I'm afraid that there was a missunderstanding:

The fix you commited does not disable links to Form Modeler (which - based on PRD should NOT be included in BRMS prouct - as opposed to BPMS product, where it should be included), but instead it enables form modeler itself. Please remove the links mentioned, so that it's impossible to navigate to form modeller from BRMS product.

Comment 4 Tihomir Surdilovic 2013-09-25 15:10:56 UTC
I am unclear of what is being asked for here. Are we asking to disable form modeler or form modeling in designer completely? Being able to create process form I think is useful in any product that allows users to create business processes and start them. WDYT? 

Please give me details on this so I know what to do - thanks!

Comment 5 Tihomir Surdilovic 2013-09-25 16:34:19 UTC
I have updated designer to not display the form creation/editing button in the menu bar nor the shapemenu option on user tasks for editing forms if on server startup we specify:

./standalone.sh -Dorg.jbpm.designer.perspective=ruleflow

if the value of org.jbpm.designer.perspective is anything else or this property is not specified at all, the form items are displayed.

Comment 6 Pere Fernàndez 2013-09-27 08:54:14 UTC
Removed form-modeler dependencies that create the Create New Form link.

Commits (master): https://github.com/droolsjbpm/kie-wb-distributions/commit/28ccedccc80495d20a229fa1fdb33c9a647294f6

Commits (6.0.x): https://github.com/droolsjbpm/kie-wb-distributions/commit/a8cb872e3ece54c1374db458557d6203c7e5aa68

Comment 10 Jan Hrcek 2013-10-17 05:43:15 UTC
Ok, verified with BRMS 6.0.0 ER4