Bug 1003694

Are you going to support EL5/6?

Yes.

1. Email address should be enclosed by <>, you can see we all do this.

2. Why do you want to support epel5? Don't you know w3lib only supports Python 2.6 or 2.7 and el5 only have 2.4.3?

3. %description is not good,

This is a Python library of web-related functions, such as:
  remove comments, or tags from HTML snippets
  extract base url from HTML snippets
  translate entites on HTML strings
  encoding mulitpart/form-data
  convert raw HTTP headers to dicts and vice-versa
  construct HTTP auth header
  converting HTML pages to unicode
  RFC-compliant url joining
  sanitize urls (like browsers do)
  extract arguments from urls

should be

This is a Python library of web-related functions, such as:
- Remove comments, or tags from HTML snippets
- Extract base url from HTML snippets
- Translate entites on HTML strings
- Encoding mulitpart/form-data
- Convert raw HTTP headers to dicts and vice-versa
- Construct HTTP auth header
- Converting HTML pages to unicode
- RFC-compliant url joining
- Sanitize urls (like browsers do)
- Extract arguments from urls

4. BuildRequires:  python-devel 

should be 

BuildRequires:  python2-devel

Spec URL: http://dbruno.fedorapeople.org/w3lib/python-w3lib.spec
SRPM URL: http://dbruno.fedorapeople.org/w3lib/python-w3lib-1.3-1.fc19.src.rpm

1. Fixed

2. I'm sorry, I mistook with another package that i'm working.

3. Fixed

4. Fixed

If this doesn't support EPEL5(As I've said it really does), please remove:

1. BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

2. rm -rf %{buildroot} in %install

3. Whole %clean section

4. %defattr(-,root,root,-)

5. %if 0%{?fedora} < 13 || 0%{?rhel} < 6
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
%endif

And, bump your spec release number to 2 if you like.

Spec URL: http://dbruno.fedorapeople.org/w3lib/python-w3lib.spec
SRPM URL: http://dbruno.fedorapeople.org/w3lib/python-w3lib-1.3-2.fc19.src.rpm

All topics were fixed.

New issues:

1.We just get news that %{__python} is deprecated like python-devel, now it's better to use %{__python2}.

2.If nothing in %clean, don't mention it anymore.

Well before I run fedora-review later, you don't need to fix them. Please fix above issues after I return the result of fedora-review.

*** Bug 1005769 has been marked as a duplicate of this bug. ***

Seems you've corrected them, nice.

1. CLEAN rm -rf %{buildroot} IN %install SECTION BEFORE SCM.

2. python-w3lib.noarch: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code

APPROVED.

New Package SCM Request
=======================
Package Name: python-w3lib
Short Description: Library of web-related functions
Owners: dbruno
Branches: f18 f19 f20
InitialCC:

Git done (by process-git-requests).

Hi,

It seems that you never build it for rawhide.

Did you forget to do that?

Thanks.

Hello,

I was looking in the logs, and I believe that I did it.

I'm sorry for the late response.

(In reply to Daniel Bruno from comment #13)
> Hello,
> 
> I was looking in the logs, and I believe that I did it.
> 
> I'm sorry for the late response.

Have a nice weekend.

But I can see that it's not.

Please search at http://dl.fedoraproject.org or http://pkgs.org

And you never do what I've told you in comment 9:

Remove rm -rf %{buildroot}

(In reply to Christopher Meng from comment #15)
> And you never do what I've told you in comment 9:
> 
> Remove rm -rf %{buildroot}

Hello,

The package was already built to rawhide.

So, about comment 9, do you recommend to build the package again without this line, or just do it in the next release?

Thank you

Do it in the next release, fix it in git.

OK. I saw you built it in Koji, fine now.