Bug 1003768
| Summary: | Review Request: lv2-x42-plugins - a collection of LV2 audio plugins | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brendan Jones <brendan.jones.it> |
| Component: | Package Review | Assignee: | Sandro Mani <manisandro> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | manisandro, notting |
| Target Milestone: | --- | Flags: | manisandro:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-10 14:45:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Brendan Jones
2013-09-03 07:27:46 UTC
- The URL for the source is missing. Please see [1] for the guidelines on github urls
- According to the ChangeLog, the version is 0.1.1
- For post-release snapshots, follow the guidelines here [2], i.e. append .git%{shortcommit} to Release
- Detail: you could replace "make install DESTDIR=%{buildroot}" by "%make_install" (see rpm -E '%make_install')
Rest looks good!
[1] http://fedoraproject.org/wiki/Packaging:SourceURL#Github
[2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
OK, there is no tag to grab the source as outlined in [1] above, so I have used a combination of it and pre-release syntax. SRPM: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19.src.rpm SPEC: http://bsjones.fedorapeople.org/reviews/lv2-x42-plugins.spec For the SOURCE URL, you could use https://github.com/x42/x42-plugins/archive/%{commit}/x42-plugins-%{commit}.tar.gz and drop the date (i.e. %prerelease) from Release. Then, you would not need to use lv2-x42-plugins-snapshot.sh anymore. But I'll leave this for you to decide. Everything else is ok. Approved! New Package SCM Request ======================= Package Name: lv2-x42-plugins Short Description: a collection of MIDI and audio plugins Owners: bsjones Branches: f18 f19 f20 InitialCC: Git done (by process-git-requests). lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc19 lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc18 lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 has been pushed to the Fedora 20 testing repository. lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19 lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc20 lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc18 lv2-x42-plugins-0.1.1-0.1.20130615git7153e34.fc20 has been pushed to the Fedora 20 stable repository. lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. lv2-x42-plugins-0.1.1-0.3.20131005git7db99d5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |