Bug 1003800

Summary: dist-geo-rep: running "make" failes to sync files to the slave
Product: [Community] GlusterFS Reporter: Venky Shankar <vshankar>
Component: geo-replicationAssignee: Csaba Henk <csaba>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: high    
Version: mainlineCC: aavati, csaba, gluster-bugs, rhs-bugs, rwheeler, vbhat, vkoppad
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.5.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 987082 Environment:
Last Closed: 2014-07-11 19:17:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 987082, 1285209    
Bug Blocks:    

Comment 1 Anand Avati 2013-09-03 10:03:55 UTC
REVIEW: http://review.gluster.org/5754 (gsyncd / geo-rep: fix "regular file" overloading rename) posted (#1) for review on master by Venky Shankar (vshankar)

Comment 2 Anand Avati 2013-09-03 10:04:26 UTC
REVIEW: http://review.gluster.org/5755 (gsyncd / geo-rep: overload rename with an unlink) posted (#1) for review on master by Venky Shankar (vshankar)

Comment 3 Anand Avati 2013-09-05 03:50:37 UTC
COMMIT: http://review.gluster.org/5754 committed in master by Anand Avati (avati) 
------
commit aa292ab99c9db37dd5080aa5d65f24a8887b855b
Author: Venky Shankar <vshankar>
Date:   Wed Aug 21 20:38:09 2013 +0530

    gsyncd / geo-rep: fix "regular file" overloading rename
    
    entry operation on the slave was using source parent gfid
    and basename when renames are overloaded to use regular file
    creation. This patch fixes the issue by using the destination
    parent gfid and basename for these cases.
    
    Change-Id: I1a4e8df7f07905224ce44ef5abd6f180234285ab
    BUG: 1003800
    Tested-by: Amar Tumballi <amarts>
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/5754
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Avra Sengupta <asengupt>
    Tested-by: Avra Sengupta <asengupt>
    Reviewed-by: Anand Avati <avati>

Comment 4 Anand Avati 2013-09-05 03:52:43 UTC
COMMIT: http://review.gluster.org/5755 committed in master by Anand Avati (avati) 
------
commit 8910136c09e11f651fe846e3f357341b9260930e
Author: Venky Shankar <vshankar>
Date:   Wed Aug 21 16:33:41 2013 +0530

    gsyncd / geo-rep: overload rename with an unlink
    
    This is certainly a "hack" for cases when after a rename
    the gfid is unlinked (which is now pointed by a different
    pargfid/basename). This was osbserved when a file edited
    (uisng vi/vim) on the glusterfs mount point which has a
    geo-replication session running.
    
    Change-Id: I0a5d9f0f549aa4403671fa1f11e95510142e5720
    BUG: 1003800
    Signed-off-by: Avra Sengupta <asengupt>
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Amar Tumballi <amarts>
    Reviewed-on: http://review.gluster.org/5755
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>