Bug 1003984
Summary: | horizon: cannot edit an image created with no params or missing params | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat OpenStack | Reporter: | Dafna Ron <dron> | ||||
Component: | python-django-horizon | Assignee: | Julie Pichon <jpichon> | ||||
Status: | CLOSED ERRATA | QA Contact: | Nir Magnezi <nmagnezi> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | unspecified | CC: | aberezin, aortega, athomas, ddomingo, hateya, jpichon, mrunge, sradvan, yeylon | ||||
Target Milestone: | rc | Keywords: | Triaged | ||||
Target Release: | 4.0 | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | storage | ||||||
Fixed In Version: | python-django-horizon-2013.2-3.el6ost | Doc Type: | Bug Fix | ||||
Doc Text: |
Cause: There was an assumption on the Horizon pages showing details of an Image, that all the image properties would be set.
Consequence: Many image properties in glance are optional and trying to display the image details for an image that for instance did not have a name would result in an error 500.
Fix: Validate that a field exists before trying to display it.
Result: The image details pages loads correctly even when there are missing attributes, and only displays the available properties.
|
Story Points: | --- | ||||
Clone Of: | Environment: | ||||||
Last Closed: | 2013-12-20 00:23:21 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 976334 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Dafna Ron
2013-09-03 16:12:51 UTC
This was fixed in Havana RC1 upstream, confirmed this is resolved in python-django-horizon-2013.2-3.el6ost. Hey, What is the new expected behavior here? I easily reproduced the glance bug (using glance image-create --name bla), but when I browse to http://<HOST>/dashboard/project/images_and_snapshots/ I can't edit the image. on the other hand, when I access that image from Admin tab: http://<HOST>/dashboard/admin/images/images/ I See an 'Edit' button, with some limited number of fields to edit: Name --> Editable Description --> Editable Kernel ID --> Grayed out, a question[1] Ramdisk ID --> Grayed out, a question[1] Architecture --> Grayed out, a question[1] Format --> Grayed out Public --> Editable Protected --> Editable When I tried to modify the name, or add a description, I got blocked with an error: This field is required. (referring to the Format field, which is grayed out) [1] Is this even suppose to be here? can remember I've seen such a field before. Before this was fixed, the dashboard would crash with an error 500 when navigating to the image details page. If you can see the image details it seems this was fixed successfully. From the regular user screen: - You should be able to edit images you own if their status is 'Active' (but I think creating an image with missing parameters means it never reaches that stage) From the admin screen: - The kernel and ramdisk id fields remind me of EC2 fields, and seem to come from the glance image 'property' dictionary. I'm guessing it's there to offer useful information when using AWS-compatible images. - Not being able to edit the format even though it is a required field isn't an ideal user experience. I believe the UI aims to optimise for the most common case, in which the format should never change over the lifetime of an image and changing it would cause problems. If this is thought to be a bug, we should file it separately from this one (I can see the point of the view from either side.) Thank you! Thanks for the detailed answer! So based on Comment #6 and Comment #7: Verified NVR: python-django-horizon-2013.2-5.el6ost.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2013-1859.html |