Bug 1004030

Summary:	Review Request: ovirt-scheduler-proxy - Scheduling Proxy for Open Virtualization
Product:	[Fedora] Fedora	Reporter:	Martin Sivák <msivak>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ppisar, sochotni
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-21 09:18:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Sivák 2013-09-03 18:10:55 UTC

Spec URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy.spec
SRPM URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy-0.1-1.fc19.src.rpm
Description: The scheduler proxy runs user defined scripts to filter and fine-tune
load-balancing of their oVirt system.
Fedora Account System Username: msivak

Please note that the fedora-review tool sees java source code, but all java files are deleted in the %prep section.

Comment 1 Martin Sivák 2013-09-05 17:02:52 UTC

Please use the new version as Juan had comments about the licensing.

Spec URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy.spec
SRPM URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy-0.1.1-1.fc19.src.rpm

Comment 2 Stanislav Ochotnicky 2013-09-10 07:34:06 UTC

Review flag ? is supposed to be set by reviewer when he starts the review :-)

Comment 3 Stanislav Ochotnicky 2013-09-10 07:56:38 UTC

First a few things which I think should be addressed before I launch a full-scale review:
 * Source tarball cannot be reproduced. Are you sure the instructions are correct? Upstream git has no tags in it...
 * If the upstream does't handle log rotation it would be a good idea to ship at least some basic logrotate configuration
 * There are example plugins and sample configurations in upstream tarball but they are not packaged. This should be fixed IMO
 * Perhaps you could use "%{name}" instead of "ovirt-scheduler-proxy" everywhere but that's up to you (it's shorter after all...)

Comment 4 Martin Sivák 2013-09-10 09:54:28 UTC

Please use a new version:

Spec URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy.spec
SRPM URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy-0.1.2-1.fc19.src.rpm

> * If the upstream does't handle log rotation it would be a good idea to ship at least some basic logrotate configuration
The daemon does it's own log rotation using logging.handlers.RotatingFileHandler

>  * Source tarball cannot be reproduced. Are you sure the instructions are correct? Upstream git has no tags in it...
It will once I get gerrit to do that for me...

Comment 5 Stanislav Ochotnicky 2013-09-16 08:32:22 UTC

I've been waiting for some change that would enable me to recreate the tarball, but this hasn't happened yet. I will not continue the review without being able to verify the tarball or you changing the package to some pre-release versioning scheme which would allow me to just check git hashes.

This is either a final 0.1.2 upstream release and there has to be tarball and/or tag in git. Otherwise I consider it a pre-release and the release tag of spec has to be changed accordingly

Comment 6 Sandro Bonazzola 2021-05-21 09:18:01 UTC

Package review was sent on Fedora 19 and upstream oVirt is not trying to support Fedora anymore.
Closing wontfix.