| Summary: | Review Request: libXaw3dXft - An extended version of Xaw3d with support for UTF8 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paulo Roma Cavalcanti <promac> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, notting |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://sourceforge.net/projects/sf-xpaint/files/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-21 13:00:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Paulo Roma Cavalcanti
2013-09-04 01:18:27 UTC
Xaw3dxft used to be part of xpaint. However, since xpaint 2.9.9, it supplied as a separate package, which is a new build requirement for updating xpaint to its latest release. Koji build for F18: http://koji.fedoraproject.org/koji/taskinfo?taskID=5893360 Koji build for F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5893377 Rpmlint output: rpmlint libXaw3dXft-1.6.2b-1.fc18.x86_64.rpm libXaw3dXft.x86_64: W: spelling-error %description -l en_US xpaint -> paint, x paint libXaw3dXft.x86_64: W: spelling-error %description -l en_US freetype -> free type, free-type, freestyle libXaw3dXft.x86_64: W: shared-lib-calls-exit /usr/lib64/libXaw3dxft.so.8.0.1 exit.5 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint libXaw3dXft-devel-1.6.2b-1.fc18.x86_64.rpm libXaw3dXft-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - rpmlint checks return: See above. It would be best to fix the exit if possible, but it may not be. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv3+ ) OK, text in %doc, matches source MIT also present, but compiled together, GPLv3+ is correct. - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Pretty straightforward. APPROVED. Thanks, Jon, for finishing this review. New Package SCM Request ======================= Package Name: libXaw3dXft Short Description: An extended version of Xaw3d with support for UTF8 Owners: roma Branches: f18 f19 f20 el5 el6 InitialCC: roma Git done (by process-git-requests). |