Bug 1004256

* Sun Sep 15 2013 Fabian Affolter <mail> - 0.1.1-1
- New download location
- Updated to new upstream release 0.1.1

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pysysbot.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pysysbot-0.1.1-1.fc19.src.rpm

%{python_sitelib}/* --> %{python2_sitelib}/*

This package depends on pystatgrab, which depends on libstatgrab. However Oliver has updated it to 0.90, now I maintain it. I'm not sure if it's compatible with each other. Good news is that they have same upstream.

We need to rebuild pystatgrab against libstatgrab 0.90.

This package looks good, only has dependency problem.

(In reply to Christopher Meng from comment #2)
> %{python_sitelib}/* --> %{python2_sitelib}/*

thanks

> We need to rebuild pystatgrab against libstatgrab 0.90.

For now I switched to psutil for pysysbot because I was not able to rebuild pystatgrab against libstatgrab 0.90. There are some gcc errrors.

* Tue Sep 17 2013 Fabian Affolter <mail> - 0.1.2-1
- Requirements updated
- License updated
- Updated to new upstream release 0.1.2

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pysysbot.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pysysbot-0.1.2-1.fc19.src.rpm

Because of too many bugs now, we have rebuilt libstatgrab to 0.17 with epoch 1.

Sorry for the inconvenience, if possible please try again after today's bodhi pushing.

(In reply to Christopher Meng from comment #4)
> Because of too many bugs now, we have rebuilt libstatgrab to 0.17 with epoch
> 1.

I cannot find any FPC / FESCo ticket for bumping epoch on libstatgrab?  Who granted permission to do so?  What's going on there?

> Sorry for the inconvenience, if possible please try again after today's
> bodhi pushing.

(In reply to Björn "besser82" Esser from comment #5)
> (In reply to Christopher Meng from comment #4)
> > Because of too many bugs now, we have rebuilt libstatgrab to 0.17 with epoch
> > 1.
> 
> I cannot find any FPC / FESCo ticket for bumping epoch on libstatgrab?  Who
> granted permission to do so?  What's going on there?
> 
> > Sorry for the inconvenience, if possible please try again after today's
> > bodhi pushing.

Hi, you should look at git repo and see who is doing this, although I'm the owner, I never touch it still.

> Who granted permission to do so?

It doesn't need permission from the FPC, and FESCo has nothing to do with it at all.  https://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_Epochs

Why not introduce a libstatgrab6 (6 for the SONAME major version) package to install alongside the upgraded libstatgrab?

> ... although I'm the owner, I never touch it still.

Is that disinterest? Or are you happy with the Epoch?

libstatgrab has been rolled back as 0.90 version breaks too many stuffs.


Package Review(truncated)
==============

1. [!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL", "GPL (v3 or later)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in
     /home/rpmaker/Desktop/pysysbot/licensecheck.txt

----------

Since you are the author of this software, I hope you can fix them in a new version(well it also depends on if a new version is ready for publish)

GPL
---
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/pysysbot-0.1.2/setup.py

GPL (v3 or later)
-----------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/pysysbot-0.1.2/pysysbot/__init__.py

Unknown or generated
--------------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/pysysbot-0.1.2/pysysbot/pysysbot.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/pysysbot-0.1.2/pysysbot/settings.py


2. [!]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/pysysbot
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/pysysbot

I think you can understand this.


-------------------Miscellaneous-------------------

Requires
--------
pysysbot (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python2
    config(pysysbot)
    python(abi)
    python-jabberbot
    python-psutil
    systemd



Provides
--------
pysysbot:
    config(pysysbot)
    pysysbot



Source checksums
----------------
https://pypi.python.org/packages/source/p/pysysbot/pysysbot-0.1.2.tar.gz :
  CHECKSUM(SHA256) this package     : 1fdf0a43bc59e8e7bb77995ebaf4f16d28a688611c9709a2bfe811c8e457e8b3
  CHECKSUM(SHA256) upstream package : 1fdf0a43bc59e8e7bb77995ebaf4f16d28a688611c9709a2bfe811c8e457e8b3


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn pysysbot-0.1.2-1.fc19.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, C/C++, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

-------------------Summary-------------------

Please fix issues found above and I will give +.

ping after a month.

Thanks for the review.

(In reply to Christopher Meng from comment #8)
> libstatgrab has been rolled back as 0.90 version breaks too many stuffs.
> 
> Package Review(truncated)
> ==============
> 
> 1. [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses found:
>      "GPL", "GPL (v3 or later)", "Unknown or generated". 2 files have unknown
>      license. Detailed output of licensecheck in
>      /home/rpmaker/Desktop/pysysbot/licensecheck.txt
> 
> Since you are the author of this software, I hope you can fix them in a new
> version(well it also depends on if a new version is ready for publish)

Thanks, there was indeed a little mess with the license statements. Should be fixed now. 

> 2. [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /etc/pysysbot
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/pysysbot
> 
> I think you can understand this.

Fixed

* Wed Jan 22 2014 Fabian Affolter <mail> - 0.1.3-1
- License update
- Update to new upstream release 0.1.3

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pysysbot.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pysysbot-0.1.3-1.fc20.src.rpm

PACKAGE APPROVED.

Christopher, thanks for the review.

New Package SCM Request
=======================
Package Name: pysysbot
Short Description: A simple python jabber bot for getting system information
Owners: fab
Branches: F19 F20
InitialCC:

Git done (by process-git-requests).

pysysbot-0.1.3-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/pysysbot-0.1.3-1.fc19

pysysbot-0.1.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/pysysbot-0.1.3-1.fc20

pysysbot-0.1.3-1.fc20 has been pushed to the Fedora 20 testing repository.

pysysbot-0.1.3-1.fc20 has been pushed to the Fedora 20 stable repository.

pysysbot-0.1.3-1.fc19 has been pushed to the Fedora 19 stable repository.