Bug 1004785

Fixed in master

Hi Mauricio

could you possibly add more description on what was wrong? Not sure from current description how to verify your fix.

Thanks.

@M

Created attachment 814491 [details]
Wrong Header.

This issues deals with the forms. Namely task and process forms which have a popup with a header that has Hard Coded the word "Form". See attached screenshot.

I had a chat with Mauricio and this issue is not yet fixed.

The header is no more an issue for tasks as the details will be opened in another frame not in a popup but it's still an issue for start process (see attached image).

the issue was solved in the following commits:

master branch: URL: http://github.com/droolsjbpm/jbpm-console-ng/commit/46de3abed

6.0.x branch: http://github.com/droolsjbpm/jbpm-console-ng/commit/7bf37ac66

Seems that the commit did not make it into sync.2014.02.10. The FormDisplayPopupPresenter still contains the old implementation of the getTitle() method:

@WorkbenchPartTitle
public String getTitle() {
    return constants.Form();
}

I browsed manually both master and 6.0.x branches in github repository and FormDisplayPopupPresenter.java has the correct code in both branches. It has the code pushed in the commits reported above.
I guess the test has been done with a build that didn't include the fix.


See:

https://github.com/droolsjbpm/jbpm-console-ng/blob/master/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskform/popup/FormDisplayPopupPresenter.java

    @WorkbenchPartTitle
    public String getTitle() {
        String title = createTitle();
        return SafeHtmlUtils.htmlEscape(title != null ? title : "");
    }

https://github.com/droolsjbpm/jbpm-console-ng/blob/6.0.x/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskform/popup/FormDisplayPopupPresenter.java

    @WorkbenchPartTitle
    public String getTitle() {
        String title = createTitle();
        return SafeHtmlUtils.htmlEscape(title != null ? title : "");
    }

Walter,

you are correct that the fix is present on github. I was talking about the repo on http://git.app.eng.bos.redhat.com/ which also hosts the repo. This source is used when building product binaries.

Please see: 

http://git.app.eng.bos.redhat.com/jbpm-console-ng.git/tree/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskform/FormDisplayPresenter.java?id=sync.2014.02.10#n388

@WorkbenchPartTitle
public String getTitle() {
    return constants.Form();
}

Marek,
thanks for the clarification. Honestly I don't know why the commit wasn't included in the tag. Because it was done at 2014-02-11. But you are right.
Now it will be included for the next product release.
Thanks.

Verified on 6.0.1.ER2.