Bug 1004960

Summary: String modified before looked up among translations
Product: [Fedora] Fedora Reporter: Göran Uddeborg <goeran>
Component: anacondaAssignee: David Shea <dshea>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint-list, dshea, g.kaviyarasu, jonathan, mkolman, sbueno, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-20.17-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-19 02:41:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Göran Uddeborg 2013-09-05 21:15:20 UTC
While translating anaconda/master, I came across the message:

    msgid "IPv4 address or %s for DHCP"

I looked up the source to see what %s could be, to get this right.  I found this code:

    Entry(_('IPv4 address or %s for DHCP' % '"dhcp"'), "ip", ...

Unless I'm mistaken, this won't work.  The string that is extracted to the po file is 'IPv4 address or %s for DHCP'.  But the argument of the "_" function will be 'IPv4 address or "dhcp" for DHCP'.  And that won't be available in any translation catalog.

Wouldn't the correct way to express this be as follows?

    Entry(_('IPv4 address or %s for DHCP') % '"dhcp"', "ip", ...

Comment 1 David Shea 2013-09-05 21:30:41 UTC
That's correct. Thanks for catching this.

Comment 2 Fedora Update System 2013-09-06 22:42:58 UTC
anaconda-20.12-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.12-1.fc20

Comment 3 Fedora Update System 2013-09-07 17:03:31 UTC
Package anaconda-20.12-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-20.12-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-16040/anaconda-20.12-1.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-09-10 00:11:40 UTC
anaconda-20.13-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.13-1.fc20

Comment 5 Fedora Update System 2013-09-10 19:48:56 UTC
anaconda-20.14-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.14-1.fc20

Comment 6 Fedora Update System 2013-09-12 01:03:57 UTC
anaconda-20.15-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.15-1.fc20

Comment 7 Fedora Update System 2013-09-14 01:05:41 UTC
anaconda-20.16-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.16-1.fc20

Comment 8 Fedora Update System 2013-09-16 17:48:48 UTC
anaconda-20.17-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/anaconda-20.17-1.fc20

Comment 9 Fedora Update System 2013-09-19 02:41:39 UTC
anaconda-20.17-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.