Bug 1005164

Summary:	Add code for syncenv_destroy() and clean up syncenv_new()
Product:	[Community] GlusterFS	Reporter:	santosh pradhan <spradhan>
Component:	libglusterfsclient	Assignee:	santosh pradhan <spradhan>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	gluster-bugs, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-10 10:37:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description santosh pradhan 2013-09-06 10:41:33 UTC

Description of problem:

1. syncenv_destroy() does not have any code i.e. empty routine. Which should have free()d the syncenv structure allocated in syncenv_new().

2. In syncenv_new(), procmax was not validated for negative value.

3. syncenv_new(): pthread_create() failure still returns the valid syncenv structure allocated instead of NULL.


Version-Release number of selected component (if applicable):


How reproducible:

N/A

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-09-06 11:29:03 UTC

REVIEW: http://review.gluster.org/5838 (libglusterfs: clean up for syncenv_new/destroy()) posted (#1) for review on master by Santosh Pradhan (spradhan)

Comment 2 Anand Avati 2013-09-11 07:23:20 UTC

REVIEW: http://review.gluster.org/5838 (libglusterfs: clean up for syncenv_new/destroy()) posted (#2) for review on master by Santosh Pradhan (spradhan)

Comment 3 Anand Avati 2013-09-12 08:40:33 UTC

REVIEW: http://review.gluster.org/5838 (libglusterfs: clean up for syncenv_new/destroy()) posted (#3) for review on master by Santosh Pradhan (spradhan)

Comment 4 Anand Avati 2013-09-12 08:48:29 UTC

REVIEW: http://review.gluster.org/5838 (libglusterfs: clean up for syncenv_new/destroy()) posted (#4) for review on master by Santosh Pradhan (spradhan)

Comment 5 santosh pradhan 2014-06-10 10:37:51 UTC


*** This bug has been marked as a duplicate of bug 1093594 ***