| Summary: | Review Request: SDL2_image - Image loading library for SDL | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, ignatenko, notting |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | SDL2_image-2.0.0-4.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-08 00:35:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Igor Gnatenko
2013-09-06 11:02:52 UTC
Good: - rpmlint checks return: SDL2_image.x86_64: W: no-manual-page-for-binary showimage Each executable in standard binary directories should have a man page. None exists. SDL2_image-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files Move README.txt into -devel - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Otherwise very clean. Move the README prior to import. APPROVED. OK. Will move README at import. New Package SCM Request ======================= Package Name: SDL2_image Short Description: Image loading library for SDL Owners: ignatenkobrain Branches: f19 f20 Git done (by process-git-requests). SDL2_image-2.0.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/SDL2_image-2.0.0-2.fc19 SDL2_image-2.0.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/SDL2_image-2.0.0-2.fc20 SDL2_image-2.0.0-4.fc20 has been pushed to the Fedora 20 testing repository. SDL2_image-2.0.0-3.fc19 has been pushed to the Fedora 19 stable repository. SDL2_image-2.0.0-4.fc20 has been pushed to the Fedora 20 stable repository. |