Bug 1005201

Summary: zend app fails to start after jenkins build with hot_deploy marker
Product: OpenShift Online Reporter: Oleg Fayans <ofayans>
Component: ContainersAssignee: Vojtech Vitek <vvitek>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.xCC: amarecek, hripps, jhonce, ofayans, qiuzhang, xtian, zhewang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-19 16:49:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Oleg Fayans 2013-09-06 12:35:15 UTC
Description of problem:
When I add a jenkins client to a zend app having the hot_deploy marker and then trigger jenkins build, the app fails to start

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Create a jenkins app
2. Create a zend app and add a hot_deploy marker to it
3. Add jenkins-client-1 cartridge to this app
4. Make some changes to the index.html of the app
5. git commit and push

Actual results:

The app stops and does not start automatically. Only starts if you do "rhc app start"

Expected results:

App does not stop, the build succeeds.

Additional info:

Reproduced on stg

Comment 1 Vojtech Vitek 2013-09-09 18:10:44 UTC
@ofayans I couldn't reproduce the issue with the following steps:

rhc app create jenkins jenkins
rhc app create zend zend-5.6 jenkins-client

cd zend
echo 1 > .openshift/markers/hot_deploy
git add .openshift/markers/hot_deploy
git commit -amhot
git push

echo 1 > php/index.php
git add php/index.php
git commit -amindex
git push

Am I missing anything? Can you please provide your full steps to reproduce?

Comment 2 Zhe Wang 2013-09-10 06:59:26 UTC
Hi, Vojtech,

I was able to reproduce this bug in devenv_3762 with the following steps:

1. create a Zend-5.6 app with a Jenkins-client added
rhc app create zendtst zend-5.6 --enable-jenkins

2. create a hot_deploy marker

3. push the change and trigger a Jenkins build

and the Jenkins log of this build is:

Stopping gear...
CLIENT_MESSAGE: Stopping Zend Server Console
Stopping Zend Server GUI [Lighttpd] [32m[OK][0m
CLIENT_MESSAGE: Stopping Zend Server JobQueue daemon
Stopping JobQueue [32m[OK][0m
CLIENT_MESSAGE: Stopping Apache
CLIENT_MESSAGE: Stopping Zend Server Monitor node
Stopping Zend Server Monitor node [32m[OK][0m
CLIENT_MESSAGE: Stopping Zend Server Deployment daemon
Stopping Deployment [32m[OK][0m
CLIENT_RESULT: Zend Server 5.6 stopped successfully
+ rsync --delete-after -azO -e /usr/libexec/openshift/cartridges/jenkins/bin/git_ssh_wrapper.sh /var/lib/openshift/522ebe2a4b224264aa000001/zend/phplib/ '522ebd624b22427d3f000211.rhcloud.com:${OPENSHIFT_ZEND_DIR}phplib/'
+ rsync --delete-after -azO -e /usr/libexec/openshift/cartridges/jenkins/bin/git_ssh_wrapper.sh /var/lib/openshift/522ebe2a4b224264aa000001/app-root/runtime/repo/ '522ebd624b22427d3f000211.rhcloud.com:${OPENSHIFT_REPO_DIR}'
+ /usr/libexec/openshift/cartridges/jenkins/bin/git_ssh_wrapper.sh 522ebd624b22427d3f000211.rhcloud.com 'gear remotedeploy'
Starting application zendtst
Not starting cartridge jenkins-client because hot deploy is enabled
TODO
Not starting cartridge zend because hot deploy is enabled
Archiving artifacts

Looks like the deployment failed to detect the presence of the hot_deploy marker and actually stopped the app's gear. However, after the deployment, it could find the marker and failed to start the stopped gear.

Comment 3 Oleg Fayans 2013-09-10 07:22:13 UTC
Reproduced on devenv_3762

The steps are the following:
1. Create jenkins server
2. Create zend app
3. Add hot_deploy marker to the zend app
4. Add jenkins client to the zend app
5. Modify index.html, git commit && push

At this step the zend cartridge of the app stops and does not start automatically.
It should not stop at all

Comment 4 Vojtech Vitek 2013-09-11 17:47:19 UTC
https://github.com/openshift/li/pull/1894

Comment 5 Jhon Honce 2013-09-11 17:50:53 UTC
Fixed in https://github.com/openshift/li/pull/1894

Comment 6 Qiushui Zhang 2013-09-12 08:07:21 UTC
Tested on devenv_3776

Tried with the following steps:
1. Create jenkins app
2. Create zend app with jenkins-client
3. Add hot_deploy marker
4. Modify index.php
5. Git push the change

After the git push, I can visit the app web page successfully.

Mark the bug as verified.