Bug 1005599

Summary:	Review Request: erfa - Essential Routines for Fundamental Astronomy
Product:	[Fedora] Fedora	Reporter:	Sergio Pascual <sergio.pasra>
Component:	Package Review	Assignee:	Christopher Meng <i>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	i, notting
Target Milestone:	---	Flags:	i: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-17 21:22:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Sergio Pascual 2013-09-08 22:22:26 UTC

Spec URL: http://guaix.fis.ucm.es/~spr/erfa.spec
SRPM URL: http://guaix.fis.ucm.es/~spr/erfa-0.0.1-1.fc19.src.rpm
Description: ERFA is a C library containing key algorithms for astronomy. It is 
based on the SOFA library published by the International Astronomical Union (IAU).
Fedora Account System Username: sergiopr

Comment 1 Christopher Meng 2013-09-08 23:02:25 UTC

- devel missing %{?_isa} tag.

- Why should we need pkgconfig when installing devel?

- devel %summary is not perfect, current one:

Headers for developing programs that will use %{name}

Ah there are not only headers...

Suggestion:

%package        devel
Summary:        Development files for %{name}
Requires:       %{name}%{?_isa} = %{version}-%{release}

%description    devel
The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.

- You don't need to add smpflag during installation.

Comment 2 Sergio Pascual 2013-09-09 11:17:01 UTC

Updated.

For the pkgconfig thing, -devel contains erfa.pc that it's installed in %{_libdir}/pkgconfig. This directory belongs to pkgconfig. If I leave out the dependecy, %{_libdir}/pkgconfig would be unowned.

Spec URL: http://guaix.fis.ucm.es/~spr/erfa.spec
SRPM URL: http://guaix.fis.ucm.es/~spr/erfa-0.0.1-2.fc19.src.rpm

Comment 3 Michael Schwendt 2013-09-09 12:08:30 UTC

A dependency on /usr/bin/pkg-config is added automatically for quite some time.

Comment 4 Christopher Meng 2013-09-09 12:52:47 UTC

(In reply to Michael Schwendt from comment #3)
> A dependency on /usr/bin/pkg-config is added automatically for quite some
> time.

Yes, that's what I want to say, thanks Michael.

And you still don't change the description of -devel

Comment 5 Sergio Pascual 2013-09-09 13:44:09 UTC

(In reply to Christopher Meng from comment #4)
> (In reply to Michael Schwendt from comment #3)
> > A dependency on /usr/bin/pkg-config is added automatically for quite some
> > time.
> 
> Yes, that's what I want to say, thanks Michael.
> 

I see, I have removed the Requires: pkgconfig

> And you still don't change the description of -devel

I have updated the Summary field also.

Spec URL: http://guaix.fis.ucm.es/~spr/erfa.spec
SRPM URL: http://guaix.fis.ucm.es/~spr/erfa-0.0.1-3.fc19.src.rpm

Comment 6 Christopher Meng 2013-09-11 23:43:01 UTC

APPROVED.

No issues found.

Comment 7 Sergio Pascual 2013-09-12 10:53:36 UTC

New Package SCM Request
=======================
Package Name: erfa
Short Description: Essential Routines for Fundamental Astronomy
Owners: sergiopr
Branches: f18 f19 f20 el5 el6
InitialCC:

Comment 8 Gwyn Ciesla 2013-09-12 12:20:40 UTC

Git done (by process-git-requests).