Bug 1005705

Summary:	Integration test RBAC module has artifactId 'wildfly-ts-integ-rbac'
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Joe Wertz <ewertz>
Component:	Testsuite	Assignee:	Joe Wertz <ewertz>
Status:	CLOSED NOTABUG	QA Contact:	Ladislav Thon <lthon>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.2.0	CC:	brian.stansberry, cdewolf, lthon, pjelinek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-27 05:11:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Joe Wertz 2013-09-09 08:53:11 UTC

Wrong information in EAP6 integration testsuite RBAC pom.xml.

artifactId and name should follow other integration module patterns.

artifactId: 
Currently: 'wildfly-ts-integ-rbac'
Recommended: 'jboss-as-integ-rbac'

name: 
Currently: 'WildFly Test Suite: Integration - Role Based Access Control'
Recommended: 'JBoss Application Server Test Suite: Integration - Role Based Access Control'

Comment 1 Brian Stansberry 2013-09-26 01:28:25 UTC

WildFly is the upstream project for EAP. Its name is no more invalid than jboss-as or "JBoss Application Server", neither of which are the official name of the product.

There is going to be more and more appearance of "WildFly" in EAP sources as code from upstream is backported. It's impossible to keep it out and IMHO it is a waste of time to try. EAP 7 will actually start from WildFly code so for sure there isn't going to be some attempt to scrub this kind of thing from the entire source code.

Comment 2 Joe Wertz 2013-09-26 03:19:17 UTC

Scrubbing it from the source would be unnecessary overkill, so the name probably isn't important since it's just a description thing, but the actual project structure, artifactId, should follow established patterns.

If we want EAP7 to follow Wildfly project structure that's fine. I'm always for fewer unnecessary changes and maintenance. If we want to even convert EAP6 to Wildfly structure to make backporting easier I'm all for it. If we mix Wildfly and EAP6 project structure though... I'm not for that at all.

Project structure should follow the pattern. wildfly-ts-integ-rbac means I can't find that project where I expect it to be, given the other 9 testsuite project artifactIds. One project shouldn't randomly break the naming pattern that way.

Neither is 'right', technically speaking, but breaking structure patterns is still wrong.

Comment 3 Brian Stansberry 2013-09-30 21:59:26 UTC

I don't much care if this module gets renamed, so long as the practice doesn't spread.

Comment 4 Ladislav Thon 2013-10-10 07:53:09 UTC

As far as I (QA) am concerned, I don't really care either. And it's a test suite component, so customer impact is probably negligible.